Skip to content

Commit 5576a2e

Browse files
committed
Add nginx logs and events to report
1 parent 50ff4ca commit 5576a2e

14 files changed

+40
-1
lines changed

tests/framework/info.go

+25
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"fmt"
55
"runtime/debug"
66

7+
. "github.com/onsi/ginkgo/v2"
78
core "k8s.io/api/core/v1"
89
"sigs.k8s.io/controller-runtime/pkg/client"
910
)
@@ -81,3 +82,27 @@ func GetBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {
8182

8283
return
8384
}
85+
86+
// AddNginxLogsAndEventsToReport adds nginx logs and events from the namespace to the report if the spec failed.
87+
func AddNginxLogsAndEventsToReport(rm ResourceManager, namespace string) {
88+
if CurrentSpecReport().Failed() {
89+
var returnLogs string
90+
91+
nginxPodNames, _ := GetReadyNginxPodNames(rm.K8sClient, namespace, rm.TimeoutConfig.GetTimeout)
92+
93+
for _, nginxPodName := range nginxPodNames {
94+
returnLogs += fmt.Sprintf("Logs for Nginx Pod %s:\n", nginxPodName)
95+
nginxLogs, _ := rm.GetPodLogs(
96+
namespace,
97+
nginxPodName,
98+
&core.PodLogOptions{Container: "nginx"},
99+
)
100+
101+
returnLogs += fmt.Sprintf(" %s\n", nginxLogs)
102+
}
103+
AddReportEntry("Nginx Logs", returnLogs, ReportEntryVisibilityNever)
104+
105+
events := GetEvents(rm, namespace)
106+
AddReportEntry("Test Events", events, ReportEntryVisibilityNever)
107+
}
108+
}

tests/suite/advanced_routing_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ var _ = Describe("AdvancedRouting", Ordered, Label("functional", "routing"), fun
4848
})
4949

5050
AfterAll(func() {
51+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
5152
cleanUpPortForward()
5253

5354
Expect(resourceManager.DeleteFromFiles(files, namespace)).To(Succeed())

tests/suite/client_settings_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ var _ = Describe("ClientSettingsPolicy", Ordered, Label("functional", "cspolicy"
5757
})
5858

5959
AfterAll(func() {
60+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
6061
cleanUpPortForward()
6162

6263
Expect(resourceManager.DeleteNamespace(namespace)).To(Succeed())

tests/suite/dataplane_perf_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ var _ = Describe("Dataplane performance", Ordered, Label("nfr", "performance"),
8888
})
8989

9090
AfterAll(func() {
91+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
9192
cleanUpPortForward()
9293

9394
Expect(resourceManager.DeleteFromFiles(files, namespace)).To(Succeed())

tests/suite/graceful_recovery_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -425,6 +425,7 @@ var _ = Describe("Graceful Recovery test", Ordered, Label("graceful-recovery"),
425425
})
426426

427427
AfterAll(func() {
428+
framework.AddNginxLogsAndEventsToReport(resourceManager, ns.Name)
428429
cleanUpPortForward()
429430
Expect(resourceManager.DeleteFromFiles(files, ns.Name)).To(Succeed())
430431
Expect(resourceManager.DeleteNamespace(ns.Name)).To(Succeed())

tests/suite/longevity_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ var _ = Describe("Longevity", Label("longevity-setup", "longevity-teardown"), fu
8282
Expect(writeTrafficResults(resultsFile, homeDir, "coffee.txt", "HTTP")).To(Succeed())
8383
Expect(writeTrafficResults(resultsFile, homeDir, "tea.txt", "HTTPS")).To(Succeed())
8484

85+
framework.AddNginxLogsAndEventsToReport(resourceManager, ns.Name)
8586
Expect(resourceManager.DeleteFromFiles(files, ns.Name)).To(Succeed())
8687
Expect(resourceManager.DeleteNamespace(ns.Name)).To(Succeed())
8788
})

tests/suite/reconfig_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,8 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("nfr", "r
437437
})
438438

439439
AfterEach(func() {
440+
framework.AddNginxLogsAndEventsToReport(resourceManager, reconfigNamespace.Name)
441+
440442
Expect(cleanupResources()).Should(Succeed())
441443
teardown(releaseName)
442444
})

tests/suite/sample_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ var _ = Describe("Basic test example", Label("functional"), func() {
4646
})
4747

4848
AfterEach(func() {
49+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
4950
cleanUpPortForward()
5051

5152
Expect(resourceManager.DeleteFromFiles(files, namespace)).To(Succeed())

tests/suite/scale_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -682,6 +682,7 @@ The logs are attached only if there are errors.
682682
})
683683

684684
AfterEach(func() {
685+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
685686
cleanUpPortForward()
686687
Expect(resourceManager.DeleteNamespace(namespace)).To(Succeed())
687688
teardown(releaseName)
@@ -900,6 +901,7 @@ var _ = Describe("Zero downtime scale test", Ordered, Label("nfr", "zero-downtim
900901
})
901902

902903
AfterAll(func() {
904+
framework.AddNginxLogsAndEventsToReport(resourceManager, ns.Name)
903905
cleanUpPortForward()
904906

905907
teardown(releaseName)

tests/suite/snippets_filter_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ var _ = Describe("SnippetsFilter", Ordered, Label("functional", "snippets-filter
6767
})
6868

6969
AfterAll(func() {
70+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
7071
Expect(resourceManager.DeleteFromFiles(snippetsFilter, namespace)).To(Succeed())
7172
})
7273

tests/suite/system_suite_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ var _ = AfterSuite(func() {
348348
AddReportEntry("Events", events, ReportEntryVisibilityNever)
349349

350350
logs = framework.GetLogs(resourceManager, ngfNamespace, releaseName)
351-
AddReportEntry("Logs", logs, ReportEntryVisibilityNever)
351+
AddReportEntry("NGF Logs", logs, ReportEntryVisibilityNever)
352352

353353
labelFilter := GinkgoLabelFilter()
354354
if !strings.Contains(labelFilter, "longevity-setup") {

tests/suite/tracing_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ var _ = Describe("Tracing", FlakeAttempts(2), Ordered, Label("functional", "trac
110110
})
111111

112112
AfterEach(func() {
113+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
113114
output, err := framework.UninstallCollector(resourceManager)
114115
Expect(err).ToNot(HaveOccurred(), string(output))
115116

tests/suite/upgrade_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ var _ = Describe("Upgrade testing", Label("nfr", "upgrade"), func() {
8383
})
8484

8585
AfterEach(func() {
86+
framework.AddNginxLogsAndEventsToReport(resourceManager, ns.Name)
8687
cleanUpPortForward()
8788

8889
Expect(resourceManager.DeleteFromFiles(files, ns.Name)).To(Succeed())

tests/suite/upstream_settings_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ var _ = Describe("UpstreamSettingsPolicy", Ordered, Label("functional", "uspolic
6161
})
6262

6363
AfterAll(func() {
64+
framework.AddNginxLogsAndEventsToReport(resourceManager, namespace)
6465
cleanUpPortForward()
6566

6667
Expect(resourceManager.DeleteNamespace(namespace)).To(Succeed())

0 commit comments

Comments
 (0)