Skip to content

Commit 42f2711

Browse files
author
Kate Osborn
committed
Add line about EPs to issue lifecycle; change label name
1 parent 6a2f182 commit 42f2711

File tree

2 files changed

+34
-15
lines changed

2 files changed

+34
-15
lines changed

ISSUE_LIFECYCLE.md

Lines changed: 33 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,56 @@
11
# Issue Lifecycle
22

3-
To ensure a balance between work carried out by the NGINX engineering team while encouraging community involvement on this project, we use the following issue lifecycle. (Note: The issue *creator* refers to the community member that created the issue. The issue *owner* refers to the NGINX team member that is responsible for managing the issue lifecycle.)
3+
To ensure a balance between work carried out by the NGINX engineering team while encouraging community involvement on
4+
this project, we use the following issue lifecycle. (Note: The issue *creator* refers to the community member that
5+
created the issue. The issue *owner* refers to the NGINX team member that is responsible for managing the issue
6+
lifecycle.)
47

58
1. New issue created by community member.
69

710

8-
2. Assign issue owner: All new issues are assigned an owner on the NGINX engineering team. This owner shepherds the issue through the subsequent stages in the issue lifecycle.
11+
2. Assign issue owner: All new issues are assigned an owner on the NGINX engineering team. This owner shepherds the
12+
issue through the subsequent stages in the issue lifecycle.
913

1014

11-
3. Determine issue type: This is done with automation where possible, and manually by the owner where necessary. The associated label is applied to the issue.
15+
3. Determine issue type: This is done with automation where possible, and manually by the owner where necessary. The
16+
associated label is applied to the issue.
1217
#### Possible Issue Types
13-
`needs more info`: The owner should use the issue to request information from the creator. If we don't receive the needed information within 7 days, automation closes the issue.
18+
`needs more info`: The owner should use the issue to request information from the creator. If we don't receive the
19+
needed information within 7 days, automation closes the issue.
1420

1521
`bug`: The implementation of a feature is not correct.
1622

17-
`proposal`: A new feature, tackling technical debt, documentation changes, or improving existing features.
23+
`proposal`: An enhancement, tackling technical debt, documentation changes, or improving existing features. In cases
24+
where the enhancement requires an [Enhancement Proposal](/docs/proposals/README.md), the additional
25+
label `needs-enhancement-proposal` will be added.
1826

1927
`question`: The owner converts the issue to a github discussion and engages the creator.
2028

2129

22-
4. Determine milestone: The owner, in collaboration with the wider team (product management & engineering), determines what milestone to attach to an issue. Generally, milestones correspond to product releases - however there are two special milestones not tied to a specific release:
30+
4. Determine milestone: The owner, in collaboration with the wider team (product management & engineering), determines
31+
what milestone to attach to an issue. Generally, milestones correspond to product releases - however there are two
32+
special milestones not tied to a specific release:
2333

24-
- Issues assigned to `backlog`: Our team is in favour of implementing the feature request/fixing the issue, however the implementation is not yet assigned to a concrete release. If and when a `backlog` issue aligns well with our roadmap, it will be scheduled for a concrete iteration. We review and update our roadmap at least once every quarter. The `backlog` list helps us shape our roadmap, but it is not the only source of input. Therefore, some `backlog` items may eventually be closed as `out of scope`, or relabelled as `backlog candidate` once it becomes clear that they do not align with our evolving roadmap.
34+
- Issues assigned to `backlog`: Our team is in favour of implementing the feature request/fixing the issue, however
35+
the implementation is not yet assigned to a concrete release. If and when a `backlog` issue aligns well with our
36+
roadmap, it will be scheduled for a concrete iteration. We review and update our roadmap at least once every
37+
quarter. The `backlog` list helps us shape our roadmap, but it is not the only source of input. Therefore,
38+
some `backlog` items may eventually be closed as `out of scope`, or relabelled as `backlog candidate` once it
39+
becomes clear that they do not align with our evolving roadmap.
2540

26-
- Issues assigned to `backlog candidate`: Our team does not intend to implement the feature/fix request described in the issue and wants the community to weigh in before we make our final decision.
41+
- Issues assigned to `backlog candidate`: Our team does not intend to implement the feature/fix request described in
42+
the issue and wants the community to weigh in before we make our final decision.
2743

28-
`backlog` issues can be labeled by the owner as `help wanted` and/or `good first issue` as appropriate.
44+
`backlog` issues can be labeled by the owner as `help wanted` and/or `good first issue` as appropriate.
2945

3046

31-
5. Promotion of `backlog candidate` issue to `backlog` issue: If an issue labelled `backlog candidate` receives more than 30 upvotes within 60 days, we promote the issue by applying the `backlog` label. While issues promoted in this manner have not been committed to a particular release, we welcome PRs from the community on them.
47+
5. Promotion of `backlog candidate` issue to `backlog` issue: If an issue labelled `backlog candidate` receives more
48+
than 30 upvotes within 60 days, we promote the issue by applying the `backlog` label. While issues promoted in this
49+
manner have not been committed to a particular release, we welcome PRs from the community on them.
3250

33-
If an issue does not make our roadmap and has not been moved to a discussion, it is closed with the label `out of scope`. The goal is to get every issue in the issues list to one of the following end states:
51+
If an issue does not make our roadmap and has not been moved to a discussion, it is closed with the
52+
label `out of scope`. The goal is to get every issue in the issues list to one of the following end states:
3453

35-
- An assigned release.
36-
- The `backlog` label.
37-
- Closed as `out of scope`.
54+
- An assigned release.
55+
- The `backlog` label.
56+
- Closed as `out of scope`.

docs/proposals/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ If there is consensus on the discussion post that the enhancement is important a
4949
maintainer will ask you to [open an issue][issue] on GitHub.
5050

5151
Not every enhancement warrants an Enhancement Proposal. _If_ the enhancement issue requires an Enhancement Proposals,
52-
the maintainers will add the label `enhancement-proposal-needed` to the issue.
52+
the maintainers will add the label `needs-enhancement-proposal` to the issue.
5353

5454
[issue]: https://github.com/nginxinc/nginx-kubernetes-gateway/issues/new?assignees=&labels=proposal&projects=&template=enhancement.md&title=
5555

0 commit comments

Comments
 (0)