Skip to content

Update master/minion allowed ingress annotations #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update master/minion allowed ingress annotations #7153

merged 2 commits into from
Jan 17, 2025

Conversation

nginx-bot
Copy link
Contributor

@nginx-bot nginx-bot commented Jan 17, 2025 •
edited by pdabelf5
Loading

Proposed changes

Update example master/minion allowed ingress annotation list. List driven by masterDenylist, minionDenylist & minionInheritanceList in internal/configs/annotations.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner January 17, 2025 09:51
@nginx-bot nginx-bot added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Jan 17, 2025
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Jan 17, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) January 17, 2025 09:53
@pdabelf5 pdabelf5 merged commit 5f8feb0 into release-4.0 Jan 17, 2025
21 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-4e09c3987b1a52b5fbf86c7735c63e5d817a9f68 branch January 17, 2025 09:56
@pdabelf5 pdabelf5 changed the title [cherry-pick] update master/minion allowed ingress annotations Update master/minion allowed ingress annotations Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nginx-bot @vepatel @pdabelf5