Skip to content

Dark theme compatibility #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fazlerabbi37 opened this issue Nov 18, 2018 · 2 comments · Fixed by #272
Closed

Dark theme compatibility #269

fazlerabbi37 opened this issue Nov 18, 2018 · 2 comments · Fixed by #272
Assignees
Labels
design Related to the design or user experience
Milestone

Comments

@fazlerabbi37
Copy link

fazlerabbi37 commented Nov 18, 2018

I just updated to Notes 2.5.0 and love the awesome work done for the Category and Status Bar feature. After the Notes update I activated the Dark Theme for the NextCloud and after the update I noticed that the editor windows is almost half of the size of my screen. Is it an exacted behavior? I haven't noticed it before.

I also noticed that the Status Bar and it's info is invisible with the Dark theme enabled. I am attaching a screenshot below for reference.

Screenshot:
image

@korelstar
Copy link
Member

Thanks for reposting this issue! If I understand you correctly, you're talking about three problems:

  1. The editor area is narrow.
  2. The editor area is white (with black text) in dark theme.
  3. The status bar is not visible in dark theme.

The first point sound like a duplicate of #182. Please have a look over there.
Points 2 and 3 are design issues that come from the dark theme. Honestly, I never tried the dark theme, until now. However, this has to be fixed!

Let's concentrate on these two points in this issue and discuss on the first point in #182.

@korelstar korelstar changed the title Editor windows size and Status Bar visiblity issue Dark theme compatibility Nov 18, 2018
@korelstar korelstar added the design Related to the design or user experience label Nov 18, 2018
@korelstar
Copy link
Member

I found another issue regarding the dark theme: navigation's icons (folder, empty folder, clock) are not shown correctly. This has to be fixed, too.

@korelstar korelstar self-assigned this Nov 20, 2018
@korelstar korelstar added this to the 2.5.1 milestone Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design or user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants