Skip to content

If the contents of the note start with a slash date the synchronization splits the note #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danjde opened this issue Aug 14, 2018 · 12 comments
Labels
needs info More details are needed in order to validate issue

Comments

@danjde
Copy link

danjde commented Aug 14, 2018

Hi Staff! ;-)
I've found an issue on Cyanogenmod 12.1, no GAPS, Nextcloud 13 and Nextcloud Notes 2.4.0, Nextcloud Notes Android App 0.18.0.

If the contents of the note start with a slash date, a new addition of information in the note and its synchronization splits the note on two or three other parts, each one contains part (but not all) of the note.

Example:

01/02/2018 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nullam orci lacus, tristique id diam eu, dapibus ullamcorper velit. Sed sem libero, semper eu ipsum vel, rutrum viverra eros.

15/05/2018 Nam dictum ligula et velit cursus, ac pellentesque augue tempor. Curabitur scelerisque risus non tellus fermentum dapibus. Integer hendrerit dapibus molestie. Sed rutrum, tortor eget dapibus finibus, lorem risus bibendum elit, a laoreet ante felis non dolor.

16/05/2018, ore 1 Integer accumsan porttitor est ut volutpat. Curabitur luctus lacus eget libero mattis, at aliquet nulla blandit. Suspendisse dolor ipsum, vulputate eget nunc eget, consectetur sagittis enim. Maecenas vestibulum dui commodo, aliquet augue ullamcorper, pulvinar massa. Vestibulum commodo est massa, et accumsan lacus porttitor nec. 

29/05/2018 Praesent eget elit ultricies, pulvinar tellus quis, maximus metus. Pellentesque ultrices elit a erat consectetur, ac commodo velit faucibus. 

30/05/2018 correzione testo GDPR newsletter e rinnovo dominio teatroscientifico.com: ore 1

Adding data into the same note, results to splits the same note on two or thre notes with a different name, inherited from the date.

@korelstar
Copy link
Member

Sorry, I can't reproduce this issue. Can you please try to create a minimal example, where this problem occurs? Then give a step by step instruction what have to be done. Please pay attention if there is an Internet connection during these steps or not.

@danjde
Copy link
Author

danjde commented Aug 16, 2018

If you give me an address, I can send you my original file, that contains some personal elements and I wouldn't expose here.

Thanks!

Davide

@korelstar
Copy link
Member

You can send me the file as attachment to github(at)korelstar.de.

@korelstar
Copy link
Member

Thanks for sending the file. You wrote two things in your README:

  1. the file "[...].txt" is the result of the "[...].txt" editing, using "Note" for Android.
    In this case the file has not been truncated, only the name changed arbitrarily by "Note".

This is normal and intended behavior of Notes: the name of the note (i.e. the file name) is generated from the first line of the note. There were many discussions on this, see e.g. #190, #116, owncloud/notes#198. If needed, please participate in the open discussion #190.

  1. in other previous situations the file was truncated in two parts and the contents of the two files were not identical, some information was missing.

This is the interesting part, since it sounds like a real bug. Please try to construct a note, where we can reproduce this. With you example data, I wasn't able to reproduce this.

@danjde
Copy link
Author

danjde commented Aug 21, 2018

This is the interesting part, since it sounds like a real bug. Please try to construct a note, where we can reproduce this. With you example data, I wasn't able to reproduce this.

Well, even I will do a file that reproduce this behavior I will send it to you.

Thanks!

@korelstar korelstar added the needs info More details are needed in order to validate issue label Aug 24, 2018
@korelstar
Copy link
Member

Any news on this? I didn't receive any file since your last comment. Does the problem still occurs?

@danjde
Copy link
Author

danjde commented Sep 25, 2018

Hi @korelstar!
No, for the moment no other files suffered the same behavior!
Do not worry that as soon as it occurs I'll show myself alive ;-)

Thanks!

Davide

@danjde
Copy link
Author

danjde commented Oct 11, 2018

Hi @korelstar !
The problem has recurred.
I had a text file between my notes, created in Linux (not from Notes), and with the extension "txt", named "MUSICA ANNI 80.txt"(with a list of 80s music).
Editing this single file on Android by "Notes" (adding the words: "Ain't Nobody; Artist Rufus and Chaka Khan; Album Pure Urban Essentials" at the end file)

the single file has been splitted into three files:

  1. i'm only Shooting Love - Time Bandits.txt
  2. JAN A P KACZMAREK ANNI 80 .txt
  3. LOVE IS LIKE OXYGEN ANNI 80.txt

Attaching the three modified files plus the previous single one file (named "MUSICA ANNI 80.txt") on "anni 80.zip"
anni 80.zip

@korelstar
Copy link
Member

The files 2. and 3. definitely didn't exist before adding the new line to "MUSICA ANNI 80.txt"? And adding the new line was definitely the only change you did?

Can you reproduce this behavior? i.e., does it always happen, when you delete the newly created files and perform the described change to "MUSICA ANNI 80.txt"?

Unfortunately, I'm still not able to reproduce this strange behavior.

@danjde
Copy link
Author

danjde commented Oct 15, 2018

The files 2. and 3. definitely didn't exist before adding the new line to "MUSICA ANNI 80.txt"? And adding the new line was definitely the only change you did?

sure!

Can you reproduce this behavior? i.e., does it always happen, when you delete the newly created files and perform the described change to "MUSICA ANNI 80.txt"?

Yes! I've revert from Linux "MUSICA ANNI 80.txt" into Nextcloud/Notes folder, adding from Android at the file end:

Example't example; Example Example Example; Example Example Example

and obtaining the same result! Now the file is renamed and the new name is:

i'm only Shooting Love - Time Bandits.txt

Unfortunately, I'm still not able to reproduce this strange behavior.

I understand, the variables involved are different!

I f you like, I can send you all my notes into a compressed file.
Also if you want I can give you an user into my Nextcloud instance for testing.

Here the file changed:
i'm only Shooting Love - Time Bandits.txt.zip

Thanks!

Davide

@danjde
Copy link
Author

danjde commented Dec 8, 2018

Hi @korelstar I think to have found the issue.
I had some notes/files where the first line didn't coincide with the title.
Updating these notes, "Notes" probably was looking for a match between the title and the first line, which he did not find and went to tilt!

Ciao!

Davide

@korelstar
Copy link
Member

It's correct, that notes renames the note based on the first line. However, this should not lead to duplicating or splitting the note.

Nevertheless, if this is fixed for you, I would like to close this issue since it wasn't reproducable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info More details are needed in order to validate issue
Projects
None yet
Development

No branches or pull requests

2 participants