vuejs: first steps based on vueexample

Author: korelstar

.eslintrc.js

@@ -0,0 +1,76 @@
+module.exports = {
+	root: true,
+	env: {
+		browser: true,
+		es6: true,
+		node: true,
+		jest: true
+	},
+	globals: {
+		t: true,
+		n: true,
+		OC: true,
+		OCA: true,
+		Vue: true,
+		VueRouter: true
+	},
+	parserOptions: {
+		parser: 'babel-eslint'
+	},
+	extends: [
+		'eslint:recommended',
+		'plugin:node/recommended',
+		'plugin:vue/essential',
+		'plugin:vue/recommended',
+		'standard'
+	],
+	plugins: ['vue', 'node'],
+	rules: {
+		// space before function ()
+		'space-before-function-paren': ['error', 'never'],
+		// curly braces always space
+		'object-curly-spacing': ['error', 'always'],
+		// stay consistent with array brackets
+		'array-bracket-newline': ['error', 'consistent'],
+		// 1tbs brace style
+		'brace-style': 'error',
+		// tabs only
+		indent: ['error', 'tab'],
+		'no-tabs': 0,
+		'vue/html-indent': ['error', 'tab'],
+		// only debug console
+		'no-console': ['error', { allow: ['error', 'warn', 'debug'] }],
+		// classes blocks
+		'padded-blocks': ['error', { classes: 'always' }],
+		// always add a trailing comma, for diff readability
+		'comma-dangle': ["error", "only-multiline"],
+		// always have the operator in front
+		'operator-linebreak': ['error', 'before'],
+		// ternary on multiline
+		'multiline-ternary': ['error', 'always-multiline'],
+		// force proper JSDocs
+		'valid-jsdoc': [2, {
+			'prefer': {
+				'return': 'returns'
+			},
+			'requireReturn': false,
+			'requireReturnDescription': false
+		}],
+		// es6 import/export and require
+		'node/no-unpublished-require': ['off'],
+		'node/no-unsupported-features/es-syntax': ['off'],
+		// space before self-closing elements
+		'vue/html-closing-bracket-spacing': 'error',
+		// code spacing with attributes
+		'vue/max-attributes-per-line': [
+			'error',
+			{
+				singleline: 3,
+				multiline: {
+					max: 3,
+					allowFirstLine: true
+				}
+			}
+		]
+	}
+};

.gitignore

@@ -1,6 +1,7 @@
 node_modules/
 *.log
-build/artifacts
+build/
+js/
 .rvm
 report
 clover.xml

.travis.yml

@@ -7,6 +7,10 @@ addons:
     packages:
     - libxml2-utils
 
+cache:
+  directories:
+    - node_modules
+
 env:
   global:
     - CORE_BRANCH=master
@@ -44,24 +48,7 @@ script:
   # - phpunit --coverage-clover clover.xml -c phpunit.xml
   # - phpunit -c phpunit.integration.xml
 
-  # execute js tests
-  - cd js
-  - npm install
-  - npm install -g gulp
-  #- gulp test
-  - gulp
-
-  # Create coverage report
-  - sh -c "if [ '$TRAVIS_PHP_VERSION' != 'hhvm' ]; then wget https://scrutinizer-ci.com/ocular.phar; fi"
-  - sh -c "if [ '$TRAVIS_PHP_VERSION' != 'hhvm' ]; then php ocular.phar code-coverage:upload --format=php-clover clover.xml; fi"
-
-#matrix:
-#  include:
-#    - php: 7.1
-#      env: DB=mysql
-#    - php: 7.0
-#      env: "DB=mysql CORE_BRANCH=stable9.1"
-#    - php: 5.6
-#      env: "DB=sqlite CORE_BRANCH=stable9"
-#  fast_finish: true
+  # build js
+  - npm run lint
+  - npm run build
 

Makefile

@@ -1,23 +1,6 @@
-#
-# Nextcloud scaffolder tool
-#
-# Copyright (C) 2013 Bernhard Posselt, <[email protected]>
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-
-# Makefile for building the project
+
+### build and sign release
+
 app_name=notes
 project_dir=$(CURDIR)/../$(app_name)
 build_dir=$(CURDIR)/build/artifacts
@@ -26,80 +9,6 @@ appstore_dir=$(build_dir)/appstore
 package_name=$(app_name)
 cert_dir=$(HOME)/.nextcloud/certificates
 
-# binary directories for running the CI tests
-firefox_bin=/usr/bin/firefox
-chrome_bin=/usr/bin/chromium
-phantomjs_bin=/usr/bin/phantomjs
-
-js_dir=$(CURDIR)/js
-js_public_dir=$(js_dir)/public
-
-# common directories
-grunt_dir=$(js_dir)/node_modules/grunt-cli/bin/grunt
-bower_dir=$(js_dir)/node_modules/bower/bin/bower
-gruntfile_dir=$(js_dir)/Gruntfile.js
-
-php_unit_tests_dir=$(CURDIR)/tests/unit
-php_integration_tests_dir=$(CURDIR)/tests/integration
-php_acceptance_tests_dir=$(CURDIR)/tests/acceptance
-
-
-
-# building the javascript
-all: build
-
-build: deps
-	mkdir -p $(js_public_dir)
-	$(grunt_dir) --config $(gruntfile_dir) build
-
-watch: build
-	$(grunt_dir) --config $(gruntfile_dir) watch:concat
-
-update: deps
-	$(bower_dir) update
-
-# testing
-tests: js-unit-tests php-unit-tests php-integration-tests php-acceptance-tests
-
-unit-tests: js-unit-tests php-unit-tests
-
-
-# testing js
-js-unit-tests: deps
-	export PHANTOMJS_BIN=$(phantomjs_bin) && \
-	$(grunt_dir) --config $(gruntfile_dir) karma:continuous
-
-watch-js-unit-tests: deps
-	export CHROME_BIN=$(chrome_bin) && export FIREFOX_BIN=$(firefox_bin) && \
-	$(grunt_dir) --config $(gruntfile_dir) karma:unit
-
-
-# testing php
-php-unit-tests: deps
-	phpunit $(php_unit_tests_dir)
-
-watch-php-unit-tests: deps
-	$(grunt_dir) --config $(gruntfile_dir) watch:phpunit
-
-php-integration-tests: deps
-	phpunit $(php_integration_tests_dir)
-
-php-acceptance-tests: deps
-	cd $(php_acceptance_tests_dir); make headless
-
-
-# general
-deps:
-	cd js
-	npm install --deps
-	cd ..
-
-clean:
-	rm -rf $(CURDIR)/node_modules
-	rm -rf $(build_dir)
-
-dist: appstore
-
 appstore: clean
 	mkdir -p $(sign_dir)
 	rsync -a \
@@ -128,10 +37,60 @@ appstore: clean
 	--exclude=js/package.json \
 	$(project_dir) $(sign_dir)
 	@echo "Signing…"
-	php ../../occ integrity:sign-app \
+	php ../server/occ integrity:sign-app \
 		--privateKey=$(cert_dir)/$(app_name).key\
 		--certificate=$(cert_dir)/$(app_name).crt\
 		--path=$(sign_dir)/$(app_name)
 	tar -czf $(build_dir)/$(app_name).tar.gz \
 		-C $(sign_dir) $(app_name)
 	openssl dgst -sha512 -sign $(cert_dir)/$(app_name).key $(build_dir)/$(app_name).tar.gz | openssl base64
+
+
+### from vueexample
+
+all: dev-setup lint build-js-production test
+
+# Dev env management
+dev-setup: clean clean-dev npm-init
+
+npm-init:
+	npm install
+
+npm-update:
+	npm update
+
+# Building
+build-js:
+	npm run dev
+
+build-js-production:
+	npm run build
+
+watch-js:
+	npm run watch
+
+# Testing
+test:
+	npm run test
+
+test-watch:
+	npm run test:watch
+
+test-coverage:
+	npm run test:coverage
+
+# Linting
+lint:
+	npm run lint
+
+lint-fix:
+	npm run lint:fix
+
+# Cleaning
+clean:
+	rm -f js/notes.js
+	rm -f js/notes.js.map
+
+clean-dev:
+	rm -rf node_modules
+