Remove unnecessary if/else statement

Removed bool test of isInitialised.
Small change to manifest.

Author: Daniel Bailey

app/src/main/AndroidManifest.xml

@@ -77,6 +77,14 @@
             android:parentActivityName="it.niedermann.owncloud.notes.android.activity.NotesListViewActivity"
             />
 
+        <activity
+            android:name="it.niedermann.owncloud.notes.android.activity.SelectSingleNoteActivity">
+
+            <intent-filter>
+                <action android:name="android.appwidget.action.APPWIDGET_CONFIGURE"/>
+            </intent-filter>
+        </activity>
+
         <receiver
             android:name=".android.activity.CreateNoteWidget"
             android:label="@string/widget_create_note">
@@ -103,13 +111,5 @@
                 android:name="android.appwidget.provider"
                 android:resource="@xml/single_note_widget_provider_info" />
         </receiver>
-
-        <activity
-            android:name="it.niedermann.owncloud.notes.android.activity.SelectSingleNoteActivity">
-
-            <intent-filter>
-                <action android:name="android.appwidget.action.APPWIDGET_CONFIGURE"/>
-            </intent-filter>
-        </activity>
     </application>
 </manifest>

app/src/main/java/it/niedermann/owncloud/notes/android/activity/SelectSingleNoteActivity.java

@@ -71,7 +71,6 @@ public void onNoteClick(int position, View v) {
         SharedPreferences.Editor sp = PreferenceManager.getDefaultSharedPreferences(this).edit();
 
         sp.putLong(SingleNoteWidget.WIDGET_KEY + mAppWidgetId, noteID);
-        sp.putBoolean(SingleNoteWidget.WIDGET_KEY + mAppWidgetId + SingleNoteWidget.INIT, true);
         sp.apply();
 
         Intent retIntent = new Intent(this, SingleNoteWidget.class);

app/src/main/java/it/niedermann/owncloud/notes/android/activity/SingleNoteWidget.java

@@ -20,7 +20,6 @@
 public class SingleNoteWidget extends AppWidgetProvider {
 
     public static final String  WIDGET_KEY = "single_note_widget";
-    public static final String  INIT = "INIT";
     private static final String TAG = SingleNoteWidget.class.getSimpleName();
 
     @Override
@@ -35,34 +34,26 @@ public void onDeleted(Context context, int[] appWidgetIds) {
         SharedPreferences.Editor sharedprefs = PreferenceManager.getDefaultSharedPreferences(context).edit();
 
         for (int appWidgetId : appWidgetIds) {
-            Log.d(TAG, "Removing " + WIDGET_KEY + appWidgetId + " from sharedprefs");
-            Log.d(TAG, "Removing " + WIDGET_KEY + appWidgetId + INIT + " from sharedprefs");
             sharedprefs.remove(WIDGET_KEY + appWidgetId);
-            sharedprefs.remove(WIDGET_KEY + appWidgetId + INIT);
         }
         sharedprefs.apply();
     }
 
     static void updateAppWidget(Context context, AppWidgetManager appWidgetManager, int appWidgetId) {
-        NoteSQLiteOpenHelper db = NoteSQLiteOpenHelper.getInstance(context);
         SharedPreferences sharedprefs = PreferenceManager.getDefaultSharedPreferences(context);
         RemoteViews views = new RemoteViews(context.getPackageName(), R.layout.widget_single_note);
         long noteID = sharedprefs.getLong(SingleNoteWidget.WIDGET_KEY + appWidgetId, -1);
-        boolean isInitialised = sharedprefs.getBoolean(SingleNoteWidget.WIDGET_KEY + appWidgetId + INIT, false);
 
         if (noteID >= 0) {
-            if (isInitialised) {
-                DBNote note = db.getNote(noteID);
-                Intent intent = new Intent(context, EditNoteActivity.class);
-                intent.putExtra(EditNoteActivity.PARAM_NOTE, note);
-                intent.putExtra(EditNoteActivity.PARAM_WIDGET_SRC, true);
-                PendingIntent pendingIntent = PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);
-                views.setOnClickPendingIntent(R.id.widget_single_note, pendingIntent);
-                views.setTextViewText(R.id.single_note_content, note.getContent());
-                appWidgetManager.updateAppWidget(appWidgetId, views);
-            } else {
-                Log.e(TAG, "Widget not initialised");
-            }
+            NoteSQLiteOpenHelper db = NoteSQLiteOpenHelper.getInstance(context);
+            DBNote note = db.getNote(noteID);
+            Intent intent = new Intent(context, EditNoteActivity.class);
+            intent.putExtra(EditNoteActivity.PARAM_NOTE, note);
+            intent.putExtra(EditNoteActivity.PARAM_WIDGET_SRC, true);
+            PendingIntent pendingIntent = PendingIntent.getActivity(context, 0, intent, PendingIntent.FLAG_UPDATE_CURRENT);
+            views.setOnClickPendingIntent(R.id.widget_single_note, pendingIntent);
+            views.setTextViewText(R.id.single_note_content, note.getContent());
+            appWidgetManager.updateAppWidget(appWidgetId, views);
         } else {
             Log.e(TAG, "Note not found");
             views.setTextViewText(R.id.single_note_content, "Note not found");