Added test cases for not allowed validator, Handled invalid keyword test case for recurisve reference and empty array case for prefixItems validator (#890)

* Added not allowed validator test cases

* Updated JAVA doc for NotAllowedValidatorTest

* Added PrefixItemsValidatorTest for exception handling test case

* Added RecursiveReferenceValidatorExceptionTest for handling invalid recursive ref keyword

* Extracted method from isValidInet6Address to get valid and important from inet6Address for further processing.

* Renamed strict variable in DurationFormat.java to make it more understandable.

* Added explaining variable for return statement in TimeFormat.java.

* Extracted a class from BaseJsonValidator with methods concerning to validation messages.

* Removed unnecessary override in BaseJsonValidator to improve code readability.

* Moved version detection related methods from AbstractJsonSchemaTestSuite to SpecVersionDetector for better cohesion across methods

Author: Ketul3012

src/main/java/com/networknt/org/apache/commons/validator/routines/InetAddressValidator.java

@@ -59,19 +59,59 @@ public class InetAddressValidator implements Serializable {
      */
     private static final InetAddressValidator VALIDATOR = new InetAddressValidator();
 
-    /** IPv4 RegexValidator */
+    /**
+     * IPv4 RegexValidator
+     */
     private final RegexValidator ipv4Validator = new RegexValidator(IPV4_REGEX);
 
     /**
      * Returns the singleton instance of this validator.
+     *
      * @return the singleton instance of this validator
      */
     public static InetAddressValidator getInstance() {
         return VALIDATOR;
     }
 
+    /**
+     * This method parse and validate the given inet6Address and return the valid inet6Address Part
+     *
+     * @param inet6Address inet6Address to be processed
+     * @return valid part of inet6Address after processing
+     */
+    private static String getValidInet6AddressPart(String inet6Address) {
+        String[] parts;
+        // remove prefix size. This will appear after the zone id (if any)
+        parts = inet6Address.split("/", -1);
+        if (parts.length > 2) {
+            return null;
+        }
+        if (parts.length == 2) {
+            if (!parts[1].matches("\\d{1,3}")) {
+                return null;
+            }
+            final int bits = Integer.parseInt(parts[1]); // cannot fail because of RE check
+            if (bits < 0 || bits > MAX_BYTE) {
+                return null;
+            }
+        }
+        // remove zone-id
+        parts = parts[0].split("%", -1);
+        if (parts.length > 2) {
+            return null;
+        }
+        // The id syntax is implementation independent, but it presumably cannot allow:
+        // whitespace, '/' or '%'
+        if ((parts.length == 2) && !parts[1].matches("[^\\s/%]+")) {
+            return null;
+        }
+        inet6Address = parts[0];
+        return inet6Address;
+    }
+
     /**
      * Checks if the specified string is a valid IPv4 or IPv6 address.
+     *
      * @param inetAddress the string to validate
      * @return true if the string validates as an IP address
      */
@@ -81,6 +121,7 @@ public boolean isValid(final String inetAddress) {
 
     /**
      * Validates an IPv4 address. Returns true if valid.
+     *
      * @param inet4Address the IPv4 address to validate
      * @return true if the argument contains a valid IPv4 address
      */
@@ -121,38 +162,14 @@ public boolean isValidInet4Address(final String inet4Address) {
 
     /**
      * Validates an IPv6 address. Returns true if valid.
+     *
      * @param inet6Address the IPv6 address to validate
      * @return true if the argument contains a valid IPv6 address
-     *
      * @since 1.4.1
      */
     public boolean isValidInet6Address(String inet6Address) {
-        String[] parts;
-        // remove prefix size. This will appear after the zone id (if any)
-        parts = inet6Address.split("/", -1);
-        if (parts.length > 2) {
-            return false; // can only have one prefix specifier
-        }
-        if (parts.length == 2) {
-            if (!parts[1].matches("\\d{1,3}")) {
-                return false; // not a valid number
-            }
-            final int bits = Integer.parseInt(parts[1]); // cannot fail because of RE check
-            if (bits < 0 || bits > MAX_BYTE) {
-                return false; // out of range
-            }
-        }
-        // remove zone-id
-        parts = parts[0].split("%", -1);
-        if (parts.length > 2) {
-            return false;
-        }
-        // The id syntax is implementation independent, but it presumably cannot allow:
-        // whitespace, '/' or '%'
-        if ((parts.length == 2) && !parts[1].matches("[^\\s/%]+")) {
-            return false; // invalid id
-        }
-        inet6Address = parts[0];
+        inet6Address = getValidInet6AddressPart(inet6Address);
+        if (inet6Address == null) return false; // invalid id
         final boolean containsCompressedZeroes = inet6Address.contains("::");
         if (containsCompressedZeroes && (inet6Address.indexOf("::") != inet6Address.lastIndexOf("::"))) {
             return false;
@@ -209,9 +226,6 @@ public boolean isValidInet6Address(String inet6Address) {
             }
             validOctets++;
         }
-        if (validOctets > IPV6_MAX_HEX_GROUPS || (validOctets < IPV6_MAX_HEX_GROUPS && !containsCompressedZeroes)) {
-            return false;
-        }
-        return true;
+        return validOctets <= IPV6_MAX_HEX_GROUPS && (validOctets >= IPV6_MAX_HEX_GROUPS || containsCompressedZeroes);
     }
 }