Skip to content

Conversation

@pieh
Copy link
Contributor

@pieh pieh commented Oct 6, 2023

Summary

netlify-cli@16 needs --cwd . to act like previous major so this PR also fixes test setup on top of bumping @netlify/ipx

Test plan

  1. Visit the Deploy Preview (insert link to specific page) ...

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

  • Check the Deploy Preview's Demo site for your PR's functionality
  • Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was
published correctly.

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for netlify-plugin-gatsby-demo-v5 ready!

Name Link
🔨 Latest commit 88f144d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo-v5/deploys/6523e3650ad3860008ba64dc
😎 Deploy Preview https://deploy-preview-676--netlify-plugin-gatsby-demo-v5.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for netlify-plugin-gatsby-demo ready!

Name Link
🔨 Latest commit 88f144d
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugin-gatsby-demo/deploys/6523e365947c670009d5a453
😎 Deploy Preview https://deploy-preview-676--netlify-plugin-gatsby-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pieh pieh changed the title chore: fix tests setup chore: fix tests setup and bump @netlify/ipx Oct 9, 2023
@pieh pieh marked this pull request as ready for review October 9, 2023 12:43
@pieh pieh requested a review from a team as a code owner October 9, 2023 12:43
Copy link

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe change the semantic prefix to fix before merging

@pieh pieh changed the title chore: fix tests setup and bump @netlify/ipx fix(deps): update dependency @netlify/ipx to ^1.4.5 Oct 9, 2023
@pieh pieh merged commit 1d956c2 into main Oct 9, 2023
@pieh pieh deleted the pieh-patch-1 branch October 9, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants