Skip to content

Migrate tests to Testkit and exclude routing context when it is null #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

Migrate tests to Testkit and exclude routing context when it is null #974

merged 1 commit into from
Aug 9, 2021

Conversation

@injectives
Copy link
Contributor

@injectives injectives commented Aug 6, 2021 •
edited
Loading

Migrated tests:

  • shouldBeAbleRunCypher -> test_should_read_successfully_using_write_session_run
  • shouldSendMultipleBookmarks -> test_send_and_receive_multiple_bookmarks_write_tx
  • shouldSendNullRoutingContextForBoltUri -> test_should_exclude_routing_context (optimization)
  • shouldLogConnectionIdInDebugMode -> not portable to Testkit, logic covered by unit tests:
    • InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnMessageHandling
    • InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnChannelError
    • ChannelActivityLoggerTest.* (formatted logging)
  • shouldSendReadAccessModeInQueryMetadata -> test_should_read_successfully_using_read_session_run
  • shouldNotSendWriteAccessModeInQueryMetadata -> test_should_read_successfully_using_write_session_run
  • shouldSendCustomerUserAgentInHelloMessage -> test_should_send_custom_user_agent_using_write_session_run

@injectives injectives force-pushed the feature/stubtests branch 5 times, most recently from 801f993 to c5b7854 Compare August 9, 2021 12:39
@injectives
Migrate tests to Testkit and exclude routing context when it is null
5e04390 
Migrated tests:
- shouldBeAbleRunCypher -> test_should_read_successfully_using_write_session_run
- shouldSendMultipleBookmarks -> test_send_and_receive_multiple_bookmarks_write_tx
- shouldSendNullRoutingContextForBoltUri -> test_should_exclude_routing_context (optimization)
- shouldLogConnectionIdInDebugMode -> not portable to Testkit, logic covered by unit tests:
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnMessageHandling
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnChannelError
  - ChannelActivityLoggerTest.* (formatted logging)
- shouldSendReadAccessModeInQueryMetadata -> test_should_read_successfully_using_read_session_run
- shouldNotSendWriteAccessModeInQueryMetadata -> test_should_read_successfully_using_write_session_run
- shouldSendCustomerUserAgentInHelloMessage -> test_should_send_custom_user_agent_using_write_session_run
@injectives injectives requested a review from gjmwoods August 9, 2021 14:11
@injectives injectives merged commit 62af57c into neo4j:4.4 Aug 9, 2021
@injectives injectives deleted the feature/stubtests branch August 9, 2021 17:06
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Aug 9, 2021
@injectives
Migrate tests to Testkit and exclude routing context when it is null (n…
3b33348 
…eo4j#974)

Migrated tests:
- shouldBeAbleRunCypher -> test_should_read_successfully_using_write_session_run
- shouldSendMultipleBookmarks -> test_send_and_receive_multiple_bookmarks_write_tx
- shouldSendNullRoutingContextForBoltUri -> test_should_exclude_routing_context (optimization)
- shouldLogConnectionIdInDebugMode -> not portable to Testkit, logic covered by unit tests:
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnMessageHandling
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnChannelError
  - ChannelActivityLoggerTest.* (formatted logging)
- shouldSendReadAccessModeInQueryMetadata -> test_should_read_successfully_using_read_session_run
- shouldNotSendWriteAccessModeInQueryMetadata -> test_should_read_successfully_using_write_session_run
- shouldSendCustomerUserAgentInHelloMessage -> test_should_send_custom_user_agent_using_write_session_run
@injectives injectives mentioned this pull request Aug 9, 2021
Merged
injectives added a commit to injectives/neo4j-java-driver that referenced this pull request Aug 10, 2021
@injectives
Migrate tests to Testkit and exclude routing context when it is null (n…
42c2105 
…eo4j#974)

Migrated tests:
- shouldBeAbleRunCypher -> test_should_read_successfully_using_write_session_run
- shouldSendMultipleBookmarks -> test_send_and_receive_multiple_bookmarks_write_tx
- shouldSendNullRoutingContextForBoltUri -> test_should_exclude_routing_context (optimization)
- shouldLogConnectionIdInDebugMode -> not portable to Testkit, logic covered by unit tests:
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnMessageHandling
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnChannelError
  - ChannelActivityLoggerTest.* (formatted logging)
- shouldSendReadAccessModeInQueryMetadata -> test_should_read_successfully_using_read_session_run
- shouldNotSendWriteAccessModeInQueryMetadata -> test_should_read_successfully_using_write_session_run
- shouldSendCustomerUserAgentInHelloMessage -> test_should_send_custom_user_agent_using_write_session_run
injectives added a commit that referenced this pull request Aug 10, 2021
@injectives
Migrate tests to Testkit and exclude routing context when it is null (#…
44835ae 
…974) (#975)

Migrated tests:
- shouldBeAbleRunCypher -> test_should_read_successfully_using_write_session_run
- shouldSendMultipleBookmarks -> test_send_and_receive_multiple_bookmarks_write_tx
- shouldSendNullRoutingContextForBoltUri -> test_should_exclude_routing_context (optimization)
- shouldLogConnectionIdInDebugMode -> not portable to Testkit, logic covered by unit tests:
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnMessageHandling
  - InboundMessageDispatcherTest.shouldCreateChannelActivityLoggerAndLogDebugMessageOnChannelError
  - ChannelActivityLoggerTest.* (formatted logging)
- shouldSendReadAccessModeInQueryMetadata -> test_should_read_successfully_using_read_session_run
- shouldNotSendWriteAccessModeInQueryMetadata -> test_should_read_successfully_using_write_session_run
- shouldSendCustomerUserAgentInHelloMessage -> test_should_send_custom_user_agent_using_write_session_run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjmwoods gjmwoods gjmwoods approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@injectives @gjmwoods