Added value conversion for char[] and short[] #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@DirkMahler have you signed the CLA agreement as documented in the Contribution Guide? |
Contributor
Author
|
Hi @injectives , it happened right now. |
Contributor
|
LGTM |
injectives
approved these changes
Jul 26, 2021
Contributor
Author
|
@injectives Thanks for accepting - it solves a problem on my side as well, so it's a win for both sides! |
|
@injectives Any chance this will get back-ported to 4.x versions? |
Contributor
I will take a look. |
injectives
pushed a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Sep 17, 2021
injectives
pushed a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Sep 17, 2021
injectives
pushed a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Oct 22, 2021
injectives
added a commit
that referenced
this pull request
Oct 22, 2021
Co-authored-by: Dirk Mahler <[email protected]>
injectives
pushed a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Oct 26, 2021
injectives
added a commit
that referenced
this pull request
Oct 26, 2021
Co-authored-by: Dirk Mahler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user of jQAssistant reported a problem when using a dedicated Neo4j instance (jqassistant-archive/jqa-core-framework#60).
The mapping framework behind jQAssistant (XO) sets properties of a node/relation using Value.parameters where the value is a Map of properties. In the described case one of the properties is of type char[] but testing revealed that short[] is not covered as well.
This PR replaces #964 .