Added authorization expired response handling #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds support for authorization expired response handling. When such error arrives the driver will mark all connections that were created on or before the creation timestamp of the receiving connection for disposal. The connections will be allowed to finish what they are doing and released back to the pool and will be disposed on the next acquire call. This update also makes sure that we always register the HELLO response handler so that we can handle the response appropriately. In addition, it adds the ROLLBACK message support to the driver backend.
injectives
force-pushed
the
feature/authorization-expired
branch
from
85381d9 to
49b26a4
Compare
gjmwoods
approved these changes
Apr 29, 2021
driver/src/test/java/org/neo4j/driver/integration/ConnectionHandlingIT.java
Outdated
Show resolved
Hide resolved
driver/src/test/java/org/neo4j/driver/internal/async/pool/NettyChannelHealthCheckerTest.java
Show resolved
Hide resolved
injectives
added a commit
to injectives/neo4j-java-driver
that referenced
this pull request
Jun 8, 2021
This improves the changes introduced in neo4j#886.
injectives
added a commit
that referenced
this pull request
Jun 8, 2021
This improves the changes introduced in #886.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for authorization expired response handling. When such error arrives the driver will mark all connections that were created on or before the creation timestamp of the receiving connection for disposal. The connections will be allowed to finish what they are doing and released back to the pool and will be disposed on the next acquire call.
This update also makes sure that we always register the HELLO response handler so that we can handle the response appropriately.
In addition, it adds the ROLLBACK message support to the driver backend.