Add new FileDrop implementation. #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuslundahl
force-pushed
the
feature/file-drop-to-editor
branch
from
240ecc9 to
c3e9a60
Compare
oskarhane
reviewed
Jun 19, 2019
Member
oskarhane
left a comment
oskarhane
left a comment
There was a problem hiding this comment.
This is a fantastic change. Much better user experience.
Just a few comments.
| setUserSelect(true) | ||
| } else if (extension === 'grass') { | ||
| fileLoader(files[0], importGrass) | ||
| const action = executeCommand(':style') |
Member
There was a problem hiding this comment.
There is a race condition here since the loading is async. The executed :style command might show the old style and not the imported one.
| "react-dnd": "^2.5.1", | ||
| "react-dnd-html5-backend": "^2.5.1", | ||
| "react-dom": "^16.8.1", | ||
| "react-dropzone": "^4.1.2", |
Member
There was a problem hiding this comment.
Something tells me that the yarn lock file should have changes when a dependency is being removed.
| export function FileDrop (props) { | ||
| const [fileHoverState, setFileHoverState] = useState(false) | ||
| const [userSelect, setUserSelect] = useState(false) | ||
| const [file, setFile] = useState(null) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:stylecommand to give feedback.changelog: Drag and drop cypher and grass files anywhere to import