Parse server config duration strings correctly #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarhane
changed the title
Applies to server config `browser.credential_timeout` No unit => x * 1000 (seconds assumed) ms => x s => x * 1000 m => x * 60 * 1000
oskarhane
force-pushed
the
3.0-parse-server-duration
branch
from
2100b98 to
0a178ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to server config
browser.credential_timeoutWhen receiving values from JMX, the units default is
s.So entering
browser.credential_timeout=60in the server config will givebrowser.credential_timeout=60when fetching from JMX.When parsing JMX values:
No unit => x * 1000 (seconds assumed)
ms => x
s => x * 1000
m => x * 60 * 1000