Skip to content

Allow dispose in full summary tests #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
injectives merged 1 commit into from
Jan 13, 2022
Merged

Allow dispose in full summary tests #357

injectives merged 1 commit into from
Jan 13, 2022

Conversation

@injectives
Copy link
Contributor

@injectives injectives commented Jan 12, 2022

No description provided.

@injectives injectives requested a review from robsdedude January 13, 2022 07:07
robsdedude
robsdedude approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️ LGTM

robsdedude
robsdedude requested changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@robsdedude robsdedude left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found this minor formatting thing.

@injectives injectives requested a review from robsdedude January 13, 2022 17:30
robsdedude
robsdedude approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@injectives injectives merged commit 3912d7f into neo4j-drivers:5.0 Jan 13, 2022
@injectives injectives deleted the feature/ds branch January 13, 2022 18:46
injectives added a commit to injectives/testkit that referenced this pull request Jan 14, 2022
@injectives
Allow dispose in full summary tests (neo4j-drivers#357)
7a7bcac
@injectives injectives mentioned this pull request Jan 14, 2022
Merged
injectives added a commit that referenced this pull request Jan 14, 2022
@injectives
Allow dispose in full summary tests (#357) (#362)
7b95dd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robsdedude robsdedude robsdedude approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@injectives @robsdedude