Add tests for eager BEGIN on beginning transactions

Author: robsdedude

tests/stub/tx_run/test_tx_run.py

@@ -113,7 +113,7 @@ def test_rollback_tx_on_session_close_finished_result(self):
         self._session = None
         self._server1.done()
 
-    def _eager_tx_run(self, script, routing=False):
+    def _eager_tx_func_run(self, script, routing=False):
         if routing:
             self._create_routing_driver()
             self._router.start(
@@ -145,9 +145,10 @@ def work(tx):
         return exc, tx_func_count
 
     @driver_feature(types.Feature.OPT_EAGER_TX_BEGIN)
-    def test_eager_begin_on_tx_run_with_disconnect_on_begin(self):
-        exc, tx_func_count = self._eager_tx_run("tx_disconnect_on_begin.script",
-                                                routing=True)
+    def test_eager_begin_on_tx_func_run_with_disconnect_on_begin(self):
+        exc, tx_func_count = self._eager_tx_func_run(
+            "tx_disconnect_on_begin.script", routing=True
+        )
         # Driver should retry tx on disconnect after BEGIN and call the tx func
         # exactly once (after the disconnect). The disconnect should make the
         # driver fetch a new routing table which will point to server2 the
@@ -160,11 +161,36 @@ def test_eager_begin_on_tx_run_with_disconnect_on_begin(self):
         self._server2.done()
 
     @driver_feature(types.Feature.OPT_EAGER_TX_BEGIN)
-    def test_eager_begin_on_tx_run_with_error_on_begin(self):
-        exc, tx_func_count = self._eager_tx_run("tx_error_on_begin.script",
-                                                routing=False)
+    def test_eager_begin_on_tx_func_run_with_error_on_begin(self):
+        exc, tx_func_count = self._eager_tx_func_run("tx_error_on_begin.script",
+                                                     routing=False)
         # Driver should raise error on non-transient error after BEGIN, and
         # never call the tx func.
         self.assertEqual("Neo.ClientError.MadeUp.Code", exc.code)
         self.assertEqual(tx_func_count, 0)
         self._server1.done()
+
+    def _eager_tx_run(self, script):
+        self._create_direct_driver()
+        self._server1.start(path=self.script_path(script))
+
+        self._session = self._driver.session("w")
+        with self.assertRaises(types.DriverError) as exc:
+            self._session.beginTransaction()
+
+        self._session.close()
+        self._session = None
+
+        return exc.exception
+
+    @driver_feature(types.Feature.OPT_EAGER_TX_BEGIN)
+    def test_eager_begin_on_tx_run_with_disconnect_on_begin(self):
+        exc = self._eager_tx_run("tx_disconnect_on_begin.script")
+        if get_driver_name() in ["python"]:
+            self.assertEqual("<class 'neo4j.exceptions.ServiceUnavailable'>",
+                             exc.errorType)
+
+    @driver_feature(types.Feature.OPT_EAGER_TX_BEGIN)
+    def test_eager_begin_on_tx_run_with_error_on_begin(self):
+        exc = self._eager_tx_run("tx_error_on_begin.script")
+        self.assertEqual("Neo.ClientError.MadeUp.Code", exc.code)