Skip to content

Commit 466a01b

Browse files
committed
Update pylint pre-commit hook to support py3.13 venvs
Without this change, running `pre-commit` inside a Python 3.13 venv results in errors as described in pylint-dev/pylint#10000 e.g.: ``` ************* Module telegram._bot telegram/_bot.py:26:0: E0611: No name 'Sequence' in module 'collections.abc' (no-name-in-module) ``` Bumping this hook required ignoring a new check added in pylint 3.3.0: `too-many-positional-arguments` as there's a significant amount of violations and picking a value for `--max-positional-arguments` seems non-trivial as there are functions with 80+ args (e.g., `Message::__init__()` in `telegram/_message.py`)
1 parent da93fe9 commit 466a01b

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ repos:
2929
hooks:
3030
- id: flake8
3131
- repo: https://github.com/PyCQA/pylint
32-
rev: v3.2.4
32+
rev: v3.3.2
3333
hooks:
3434
- id: pylint
3535
files: ^(?!(tests|docs)).*\.py$

AUTHORS.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ The following wonderful people contributed directly or indirectly to this projec
8181
- `LRezende <https://github.com/lrezende>`_
8282
- `Luca Bellanti <https://github.com/Trifase>`_
8383
- `Lucas Molinari <https://github.com/lucasmolinari>`_
84+
- `Luis Pérez <https://github.com/nemacysts>`_
8485
- `macrojames <https://github.com/macrojames>`_
8586
- `Matheus Lemos <https://github.com/mlemosf>`_
8687
- `Michael Dix <https://github.com/Eisberge>`_

pyproject.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,8 @@ enable = ["useless-suppression"]
149149
disable = ["duplicate-code", "too-many-arguments", "too-many-public-methods",
150150
"too-few-public-methods", "broad-exception-caught", "too-many-instance-attributes",
151151
"fixme", "missing-function-docstring", "missing-class-docstring", "too-many-locals",
152-
"too-many-lines", "too-many-branches", "too-many-statements", "cyclic-import"
152+
"too-many-lines", "too-many-branches", "too-many-statements", "cyclic-import",
153+
"too-many-positional-arguments",
153154
]
154155

155156
[tool.pylint.main]

0 commit comments

Comments
 (0)