Skip to content

Conversation

@Proxy-99
Copy link
Contributor

@Proxy-99 Proxy-99 commented Jul 14, 2024

Fixing #2317
no longer need to use setTimer or clientRender for setTime() function
fix sky flickers too much

added new functions

setTimeFrozen(true)
local get = isTimeFrozen()
resetTimeFrozen()
print(get)

thanks to @FileEX for memory addresses locations and help

@Proxy-99 Proxy-99 requested review from FileEX and TracerDS July 15, 2024 13:22
@Proxy-99 Proxy-99 requested a review from FileEX July 16, 2024 13:43
@FileEX
Copy link
Member

FileEX commented Jul 16, 2024

I'm not sure this should be in CWeatherSA as it has little to do with weather. The code toggles the call to CClock::Update, so in my opinion this should be in CClockSA as that is the class responsible for the clock & time.

@Proxy-99
Copy link
Contributor Author

I'm not sure this should be in CWeatherSA as it has little to do with weather. The code toggles the call to CClock::Update, so in my opinion this should be in CClockSA as that is the class responsible for the clock & time.

done (d502388)

@FileEX
Copy link
Member

FileEX commented Jul 16, 2024

It seems to me that "timer cycle" does not fit here.
I propose

  • SetClockFrozen
  • IsClockFrozen
  • ResetClockFrozenState (or something?)

@Proxy-99
Copy link
Contributor Author

Proxy-99 commented Jul 16, 2024

It seems to me that "timer cycle" does not fit here. I propose

  • SetClockFrozen
  • IsClockFrozen
  • ResetClockFrozenState (or something?)

I added setTimeFrozen(true)
isTimeFrozen()
resetTimeFrozen()
(ff757de)

@Proxy-99 Proxy-99 requested review from FileEX and TracerDS July 16, 2024 19:31
@Proxy-99 Proxy-99 changed the title Freeze Timer Freeze Time functions Jul 16, 2024
@tederis tederis added the bugfix Solution to a bug of any kind label Jul 17, 2024
@Proxy-99 Proxy-99 requested a review from FileEX July 17, 2024 15:17
Copy link
Member

@FileEX FileEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, lgtm

@Dutchman101 Dutchman101 merged commit b8b7ce5 into multitheftauto:master Aug 14, 2024
MTABot pushed a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Solution to a bug of any kind

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants