Skip to content

impl Radix for RevOrd isn’t helpful since RevOrd isn’t Copy #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andersk opened this issue May 2, 2018 · 1 comment
Closed

Comments

@andersk
Copy link

andersk commented May 2, 2018

All the RadixHeapMap operations require K: Radix + Ord + Copy. It seems the intended way to make a min-heap is via the RevOrd wrapper, for which a Radix implementation is defined. But RevOrd can’t actually be used since it doesn’t derive Copy.

Perhaps a Radix impl for std::cmp::Reverse should be added, since Reverse derives Copy at least in 1.26 beta (rust-lang/rust#47379).

@mpdn
Copy link
Owner

mpdn commented May 21, 2018

Yeah, now that std has a official reverse order wrapper, it would no doubt be best to use that. I have just pushed a bunch of changes to 0.3 to update it to more modern Rust, including Reverse support.

@mpdn mpdn closed this as completed May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants