Skip to content

Commit ca472df

Browse files
majidomoz-wptsync-bot
authored andcommitted
Bug 1666793 [wpt PR 25710] - Rename Sms{Service,Receiver} to WebOTPService, a=testonly
Automatic update from web-platform-tests Rename Sms{Service,Receiver} to WebOTPService The old name does not reflect the changes made to the feature name and specification. No change in functionality is expected. The following changes were made using grep & sed. - rename files - [^_]+sms_service->webotp_service - [^_]+sms_receiver->webotp_service - {SMS,Sms}Receiver->WebOTPService - SmsService->WebOTPService - SMS Service->WebOTP Service The only manual change were: - update some outdated documentation in webotp_service.mojom - SMSReceiver -> WebOTP for flags ## Aside Getting a pre-submit warning which seems incorrect as we have not changes the UMA histogram name and it exists :-? ``` ** Presubmit Warnings ** Some UMA_HISTOGRAM lines have been modified and the associated histogram name has no match in either tools/metrics/histograms/histograms.xml or the modifications of it: [components/browser_ui/sms/android/java/src/org/chromium/components/browser_ui/sms/WebOTPServiceUma.java:35] Blink.Sms.Receive.TimeCancelOnKeyboardDismissal ``` Bug:1117238 Change-Id: I369f8631450b0a539b3c2afbf8d4ed87ce853a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424707 Commit-Queue: Majid Valipour <[email protected]> Reviewed-by: Alexei Svitkine <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Reviewed-by: Sam Goto <[email protected]> Reviewed-by: Yi Gu <[email protected]> Cr-Commit-Position: refs/heads/master@{#816889} -- wpt-commits: 1b0f824f9ef09f035d2549ab4f6c92131ba62c0f wpt-pr: 25710
1 parent 119ecc2 commit ca472df

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

testing/web-platform/tests/credential-management/support/otpcredential-helper.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const Status = {};
1313
async function loadChromiumResources() {
1414
const resources = [
1515
'/gen/mojo/public/mojom/base/time.mojom-lite.js',
16-
'/gen/third_party/blink/public/mojom/sms/sms_receiver.mojom-lite.js',
16+
'/gen/third_party/blink/public/mojom/sms/webotp_service.mojom-lite.js',
1717
];
1818

1919
await loadMojoResources(resources, true);

testing/web-platform/tests/resources/chromium/mock-sms-receiver.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
const SmsProvider = (() => {
44

5-
class MockSmsReceiver {
5+
class MockWebOTPService {
66

77
constructor() {
8-
this.mojoReceiver_ = new blink.mojom.SmsReceiverReceiver(this);
8+
this.mojoReceiver_ = new blink.mojom.WebOTPServiceReceiver(this);
99

1010
this.interceptor_ =
11-
new MojoInterfaceInterceptor(blink.mojom.SmsReceiver.$interfaceName);
11+
new MojoInterfaceInterceptor(blink.mojom.WebOTPService.$interfaceName);
1212

1313
this.interceptor_.oninterfacerequest = (e) => {
1414
this.mojoReceiver_.$.bindHandle(e.handle);
@@ -35,15 +35,15 @@ const SmsProvider = (() => {
3535
}
3636
}
3737

38-
const mockSmsReceiver = new MockSmsReceiver();
38+
const mockWebOTPService = new MockWebOTPService();
3939

4040
class SmsProviderChromium {
4141
constructor() {
4242
Object.freeze(this); // Make it immutable.
4343
}
4444

4545
pushReturnValuesForTesting(callName, callback) {
46-
mockSmsReceiver.pushReturnValuesForTesting(callName, callback);
46+
mockWebOTPService.pushReturnValuesForTesting(callName, callback);
4747
}
4848
}
4949

0 commit comments

Comments
 (0)