You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Automatic update from web-platform-tests
Rename Sms{Service,Receiver} to WebOTPService
The old name does not reflect the changes made to the feature name
and specification. No change in functionality is expected.
The following changes were made using grep & sed.
- rename files
- [^_]+sms_service->webotp_service
- [^_]+sms_receiver->webotp_service
- {SMS,Sms}Receiver->WebOTPService
- SmsService->WebOTPService
- SMS Service->WebOTP Service
The only manual change were:
- update some outdated documentation in webotp_service.mojom
- SMSReceiver -> WebOTP for flags
## Aside
Getting a pre-submit warning which seems incorrect as we have not
changes the UMA histogram name and it exists :-?
```
** Presubmit Warnings **
Some UMA_HISTOGRAM lines have been modified and the associated histogram name has no match in either tools/metrics/histograms/histograms.xml or the modifications of it:
[components/browser_ui/sms/android/java/src/org/chromium/components/browser_ui/sms/WebOTPServiceUma.java:35] Blink.Sms.Receive.TimeCancelOnKeyboardDismissal
```
Bug:1117238
Change-Id: I369f8631450b0a539b3c2afbf8d4ed87ce853a87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424707
Commit-Queue: Majid Valipour <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Reviewed-by: Sam Goto <[email protected]>
Reviewed-by: Yi Gu <[email protected]>
Cr-Commit-Position: refs/heads/master@{#816889}
--
wpt-commits: 1b0f824f9ef09f035d2549ab4f6c92131ba62c0f
wpt-pr: 25710
0 commit comments