bot: Use public download url for artifacts, refs taskcluster/taskcluster-proxy#44 (#210)

Author: La0

bot/code_coverage_bot/taskcluster.py

@@ -5,11 +5,13 @@
 from zipfile import is_zipfile
 
 import requests
+import structlog
 import taskcluster
 
 from code_coverage_bot.utils import retry
 from code_coverage_tools.taskcluster import TaskclusterConfig
 
+logger = structlog.getLogger(__name__)
 taskcluster_config = TaskclusterConfig()
 
 
@@ -77,8 +79,11 @@ def download_artifact(artifact_path, task_id, artifact_name):
         return artifact_path
 
     # Build artifact public url
-    queue = taskcluster_config.get_service("queue")
+    # Use un-authenticated Taskcluster client to avoid taskcluster-proxy rewrite issue
+    # https://github.com/taskcluster/taskcluster-proxy/issues/44
+    queue = taskcluster.Queue({"rootUrl": "https://taskcluster.net"})
     url = queue.buildUrl("getLatestArtifact", task_id, artifact_name)
+    logger.debug("Downloading artifact", url=url)
 
     def perform_download():
         r = requests.get(url, stream=True)

bot/tests/test_taskcluster.py

@@ -260,14 +260,14 @@ def test_get_platform(task_name, expected):
 def test_download_artifact_forbidden(mocked_sleep, mock_taskcluster, tmpdir):
     responses.add(
         responses.GET,
-        "http://taskcluster.test/api/queue/v1/task/FBdocjnAQOW_GJDOfmgjxw/artifacts/public%2Ftest_info%2Fcode-coverage-grcov.zip",  # noqa
+        "https://queue.taskcluster.net/v1/task/FBdocjnAQOW_GJDOfmgjxw/artifacts/public%2Ftest_info%2Fcode-coverage-grcov.zip",  # noqa
         body="xml error...",
         status=403,
     )
 
     with pytest.raises(
         requests.exceptions.HTTPError,
-        match="403 Client Error: Forbidden for url: http://taskcluster.test/api/queue/v1/task/FBdocjnAQOW_GJDOfmgjxw/artifacts/public%2Ftest_info%2Fcode-coverage-grcov.zip",  # noqa
+        match="403 Client Error: Forbidden for url: https://queue.taskcluster.net/v1/task/FBdocjnAQOW_GJDOfmgjxw/artifacts/public%2Ftest_info%2Fcode-coverage-grcov.zip",  # noqa
     ):
         taskcluster.download_artifact(
             os.path.join(tmpdir.strpath, "windows_reftest-6_code-coverage-grcov.zip"),
@@ -282,7 +282,7 @@ def test_download_artifact_forbidden(mocked_sleep, mock_taskcluster, tmpdir):
 def test_download_artifact_badzip(mocked_sleep, mock_taskcluster, tmpdir):
     responses.add(
         responses.GET,
-        "http://taskcluster.test/api/queue/v1/task/FBdocjnAQOW_GJDOfmgjxw/artifacts/public%2Ftest_info%2Fcode-coverage-grcov.zip",  # noqa
+        "https://queue.taskcluster.net/v1/task/FBdocjnAQOW_GJDOfmgjxw/artifacts/public%2Ftest_info%2Fcode-coverage-grcov.zip",  # noqa
         body="NOT A ZIP FILE",
         status=200,
         stream=True,