Skip to content
This repository was archived by the owner on Oct 4, 2021. It is now read-only.

Commit fdabca2

Browse files
committed
[NuGet] Fix license expression links in License Acceptance dialog
Using the non-native XWT toolkit to display the dialog allows the hyperlinks to be clicked. It also fixes the scrollbars showing a whitebackground, even when not used. Looked at adding the resize logic back, which would reduce the height of the dialog based on the contents. However using the XWT toolkit which is non-native (GTK#) the dialog is displayed first and then resized so you can see it shrink. Instead the dialog does not resize to fit its contents which leaves some empty space.
1 parent 8c635f2 commit fdabca2

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

main/src/addins/MonoDevelop.PackageManagement/MonoDevelop.PackageManagement/LicenseAcceptanceService.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,13 @@ Task<bool> ShowLicenseAcceptanceDialog (IEnumerable<NuGetPackageLicense> license
4747
{
4848
var res = new TaskCompletionSource<bool> ();
4949
IdeApp.RunWhenIdle (() => {
50-
Xwt.Toolkit.NativeEngine.Invoke (delegate {
50+
// Disable use of native toolkit since hyperlinks cannot be clicked with the Xamarin.Mac LabelBackend
51+
// Also scrollbars are always visible even when they are not needed.
52+
//Xwt.Toolkit.NativeEngine.Invoke (delegate {
5153
using (LicenseAcceptanceDialog dialog = CreateLicenseAcceptanceDialog (licenses)) {
5254
res.SetResult (dialog.Run (Xwt.MessageDialog.RootWindow));
5355
}
54-
});
56+
//});
5557
});
5658
return res.Task;
5759
}

0 commit comments

Comments
 (0)