DRIVERS-2265: Tests for aggregate allowDiskUse option #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
approved these changes
Apr 12, 2022
Contributor
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
Happened to see this and was curious if Java driver already passes the new tests: it does.
One nit, but LGTM either way.
benjirewis
approved these changes
Apr 12, 2022
Contributor
benjirewis
left a comment
benjirewis
left a comment
There was a problem hiding this comment.
Passes in the Go driver; LGTM mod @jyemin's typo callout.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/DRIVERS-2265
PHPLIB POC: mongodb/mongo-php-library#913