feat(NODE-7122): exponential backoff between retries in convenient transaction API #4765
+122
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Outdated
Show resolved
Hide resolved
baileympearson
force-pushed
the
NODE-7122
branch
from
b6c76a9 to
7ac265d
Compare
baileympearson
force-pushed
the
NODE-7122
branch
from
4073776 to
3dad6c2
Compare
baileympearson
changed the title
baileympearson
commented
Nov 25, 2025
durran
added
the
Primary Review
durran
requested changes
Nov 26, 2025
| @@ -1,3 +1,5 @@ | |||
| import { setTimeout } from 'timers/promises'; | |||
Member
There was a problem hiding this comment.
Can we implement this without using Node's API? I feel like adding this conflicts with our Pluggable IO epic.
Contributor
Author
There was a problem hiding this comment.
setTimeout is out of scope for the project and we have many other usages of this API in the driver, so I'd prefer not to diverge from what the driver already does.
test/integration/transactions-convenient-api/transactions-convenient-api.prose.test.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
This PR adds exponential backoff between convenient transaction API failures if the transaction must be restarted.
Release Highlight
withTransactionnow applies exponential backoff during transaction retriesThe convenient transaction API now uses exponential backoff between retries, if a transaction must be retried. Under scenarios of high server load, this can prevent transaction retry storms.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript