-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-6631): Implement integration tests for improved client.close() - sockets + timers #4361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cript vars/functions
|
There is an existing patch(es) for this commit SHA: Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'. |
617e9af to
13a7f27
Compare
9793c44 to
f003454
Compare
e97cc3c to
4865259
Compare
updated tests delete extraneous files srv test lint
4865259 to
59fda80
Compare
9cfddee to
ddb638d
Compare
requested changes lint
ddb638d to
13a8a25
Compare
…e() - sockets + timers (#4361) Co-authored-by: Anna Henningsen <[email protected]>
Description
Add socket integration tests for client.close().
What is changing?
libuvtracking for each relevant driver instance of socket creation.process.getActiveResourceInfo()MonitorInterval's timer exitsTo see more information regarding testing plan outline see the design document, specifically the dropdowns under Sockets and Timers sections, respectively.
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Improved client.close()
Release Highlight
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript