Skip to content

Commit cce8652

Browse files
committed
WIP
1 parent f995966 commit cce8652

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

pipeline.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,8 @@ def should_skip_arm64():
728728
"""
729729
return is_running_in_evg_pipeline() and is_running_in_patch()
730730

731-
731+
# build_image_daily is always called, it is not only used for daily builds. build_image_generic calls
732+
# build_image_daily for the release and PR builds too.
732733
def build_image_daily(
733734
image_name: str, # corresponds to the image_name in the release.json
734735
min_version: str = None,
@@ -781,6 +782,7 @@ def inner(build_configuration: BuildConfiguration):
781782

782783
args = args_for_daily_image(image_name)
783784
args["build_id"] = build_id()
785+
# TODO: add span for build_id
784786

785787
completed_versions = set()
786788

@@ -1390,6 +1392,9 @@ def gather_latest_agent_versions(release: Dict) -> List[Tuple[str, str]]:
13901392
return sorted(list(set(agent_versions_to_build)))
13911393

13921394

1395+
# First a context image is created, a ops-manager-context:v1.33
1396+
# Daily builds exist because to mitigate CVEs as soon as possible and overwrite existing tags.
1397+
# Contexts are used by customers without using the operating image.
13931398
def get_builder_function_for_image_name() -> Dict[str, Callable]:
13941399
"""Returns a dictionary of image names that can be built."""
13951400

@@ -1411,7 +1416,8 @@ def get_builder_function_for_image_name() -> Dict[str, Callable]:
14111416
"init-database": build_init_database,
14121417
"init-ops-manager": build_init_om_image,
14131418
#
1414-
# Daily builds
1419+
# Daily builds re-use context images from non-daily builds. Daily builds are only executed daily,
1420+
# all other builds are executed on release, patches and PRs.
14151421
"operator-daily": build_image_daily("mongodb-kubernetes"),
14161422
"appdb-daily": build_image_daily("appdb"),
14171423
"database-daily": build_image_daily("database"),

0 commit comments

Comments
 (0)