Skip to content

Commit 03e8ce8

Browse files
committed
WIP
1 parent b9ade1c commit 03e8ce8

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

pipeline.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,8 @@ def should_skip_arm64():
713713
"""
714714
return is_running_in_evg_pipeline() and is_running_in_patch()
715715

716-
716+
# build_image_daily is always called, it is not only used for daily builds. build_image_generic calls
717+
# build_image_daily for the release and PR builds too.
717718
def build_image_daily(
718719
image_name: str, # corresponds to the image_name in the release.json
719720
min_version: str = None,
@@ -774,6 +775,7 @@ def inner(build_configuration: BuildConfiguration):
774775

775776
args = args_for_daily_image(image_name)
776777
args["build_id"] = build_id()
778+
# TODO: add span for build_id
777779

778780
completed_versions = set()
779781

@@ -1392,6 +1394,9 @@ def gather_latest_agent_versions(release: Dict) -> List[Tuple[str, str]]:
13921394
return sorted(list(set(agent_versions_to_build)))
13931395

13941396

1397+
# First a context image is created, a ops-manager-context:v1.33
1398+
# Daily builds exist because to mitigate CVEs as soon as possible and overwrite existing tags.
1399+
# Contexts are used by customers without using the operating image.
13951400
def get_builder_function_for_image_name() -> Dict[str, Callable]:
13961401
"""Returns a dictionary of image names that can be built."""
13971402

@@ -1413,7 +1418,8 @@ def get_builder_function_for_image_name() -> Dict[str, Callable]:
14131418
"init-database": build_init_database,
14141419
"init-ops-manager": build_init_om_image,
14151420
#
1416-
# Daily builds
1421+
# Daily builds re-use context images from non-daily builds. Daily builds are only executed daily,
1422+
# all other builds are executed on release, patches and PRs.
14171423
"operator-daily": build_image_daily("mongodb-kubernetes"),
14181424
"appdb-daily": build_image_daily("appdb"),
14191425
"database-daily": build_image_daily("database"),

0 commit comments

Comments
 (0)