Optimize rename using a single updateMany command

Author: GromNaN

src/GridFS/CollectionWrapper.php

@@ -253,6 +253,17 @@ public function insertFile($file): void
         $this->filesCollection->insertOne($file);
     }
 
+    /**
+     * Updates the filename field in the file document for all the files with a given filename.
+     */
+    public function updateFilenameForFilename(string $filename, string $newFilename): UpdateResult
+    {
+        return $this->filesCollection->updateMany(
+            ['filename' => $filename],
+            ['$set' => ['filename' => $newFilename]],
+        );
+    }
+
     /**
      * Updates the filename field in the file document for a given ID.
      *

src/GridFS/ReadableStream.php

@@ -19,16 +19,17 @@
 
 use Iterator;
 use MongoDB\BSON\Binary;
-use MongoDB\BSON\Document;
 use MongoDB\Driver\CursorInterface;
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\GridFS\Exception\CorruptFileException;
+use MongoDB\GridFS\Exception\LogicException;
 
 use function assert;
 use function ceil;
 use function floor;
 use function is_integer;
 use function is_object;
+use function is_string;
 use function property_exists;
 use function sprintf;
 use function strlen;
@@ -179,24 +180,16 @@ public function readBytes(int $length): string
 
     /**
      * Rename all revisions of the file.
-     *
-     * @return int The number of revisions renamed
      */
-    public function rename(string $newFilename): int
+    public function rename(string $newFilename): bool
     {
-        /** @var Document[] $revisions */
-        $revisions = $this->collectionWrapper->findFiles(
-            ['filename' => $this->file->filename],
-            ['typeMap' => ['root' => 'bson'], 'projection' => ['_id' => 1]],
-        );
-        $count = 0;
-
-        foreach ($revisions as $revision) {
-            $this->collectionWrapper->updateFilenameForId($revision->get('_id'), $newFilename);
-            $count++;
+        if (! isset($this->file->filename) || ! is_string($this->file->filename)) {
+            throw new LogicException('Cannot rename file without a filename');
         }
 
-        return $count;
+        $result = $this->collectionWrapper->updateFilenameForFilename($this->file->filename, $newFilename);
+
+        return $result->isAcknowledged();
     }
 
     /**

src/GridFS/StreamWrapper.php

@@ -114,7 +114,7 @@ public function rename(string $fromPath, string $toPath): bool
         $newName = explode('/', $toPath, 4)[3] ?? '';
         assert($this->stream instanceof ReadableStream);
 
-        return $this->stream->rename($newName) > 0;
+        return $this->stream->rename($newName);
     }
 
     /**