PHPLIB-954: Add return types to all methods (#1391)

* Test with PHPC 2.0

Squashed commit of the following:

commit bc37a4b83e86edba06f97148d9a1b4a194623097
Author: Andreas Braun <[email protected]>
Date:   Thu Sep 19 13:32:18 2024 +0200

    TMP: Use branch reporting 2.0 version for testing

commit 938c4cd5be825b605a01e1f3129a2e233c62ac1b
Author: Andreas Braun <[email protected]>
Date:   Wed Sep 18 10:49:01 2024 +0200

    Update CI config to test with ext-mongodb 2.0

commit 23b11ec
Author: Andreas Braun <[email protected]>
Date:   Wed Sep 18 10:47:33 2024 +0200

    Require ext-mongodb 2.0

* Remove compatibility layer for CursorId deprecation

Squashed commit of the following:

commit b06bffe
Author: Andreas Braun <[email protected]>
Date:   Thu Sep 19 12:56:07 2024 +0200

    Update psalm baseline

commit bb4bb56
Author: Andreas Braun <[email protected]>
Date:   Thu Sep 19 12:55:52 2024 +0200

    Remove CursorInterface::getId compatibility layer

commit 00fa5e4
Author: Andreas Braun <[email protected]>
Date:   Thu Sep 19 12:55:32 2024 +0200

    Add temporary stubs for cursor classes in 2.x

* PHPLIB-954: Add return types to all methods

* PHPLIB-1114: Replace Cursor types with CursorInterface

* Add upgrade note

Author: alcaeus

.evergreen/config/generated/build/build-extension.yml

@@ -5,11 +5,11 @@
         vars:
           PHP_VERSION: "%phpVersion%"
       - func: "compile extension"
-        # TODO: remove once 1.20.0 is released
+        # TODO: remove once 2.0.0 is released
         vars:
-          EXTENSION_BRANCH: "v1.20"
+          EXTENSION_BRANCH: "v2.x"
       - func: "upload extension"
-  # TODO: re-enable once 1.20.0 is released
+  # TODO: re-enable once 2.0.0 is released
 #  - name: "build-php-%phpVersion%-lowest"
 #    tags: ["build", "php%phpVersion%", "lowest", "pr", "tag"]
 #    commands:
@@ -18,7 +18,7 @@
 #          PHP_VERSION: "%phpVersion%"
 #      - func: "compile extension"
 #        vars:
-#          EXTENSION_VERSION: "1.20.0"
+#          EXTENSION_VERSION: "2.0.0"
 #      - func: "upload extension"
 #  - name: "build-php-%phpVersion%-next-stable"
 #    tags: ["build", "php%phpVersion%", "next-stable", "pr", "tag"]
@@ -28,7 +28,7 @@
 #          PHP_VERSION: "%phpVersion%"
 #      - func: "compile extension"
 #        vars:
-#          EXTENSION_BRANCH: "v1.20.0"
+#          EXTENSION_BRANCH: "v2.0"
 #      - func: "upload extension"
 #  - name: "build-php-%phpVersion%-next-minor"
 #    tags: ["build", "php%phpVersion%", "next-minor"]
@@ -38,5 +38,5 @@
 #          PHP_VERSION: "%phpVersion%"
 #      - func: "compile extension"
 #        vars:
-#          EXTENSION_BRANCH: "master"
+#          EXTENSION_BRANCH: "v2.x"
 #      - func: "upload extension"

.evergreen/config/templates/build/build-extension.yml

@@ -13,9 +13,9 @@ on:
 
 env:
   PHP_VERSION: "8.2"
-  # TODO: change to "stable" once 1.20.0 is released
+  # TODO: change to "stable" once 2.0.0 is released
   # DRIVER_VERSION: "stable"
-  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.20"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v2.x"
 
 jobs:
   phpcs:

.github/workflows/coding-standards.yml

@@ -13,9 +13,9 @@ on:
 
 env:
   PHP_VERSION: "8.2"
-  # TODO: change to "stable" once 1.20.0 is released
+  # TODO: change to "stable" once 2.0.0 is released
   # DRIVER_VERSION: "stable"
-  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.20"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v2.x"
 
 jobs:
   psalm:

.github/workflows/generator.yml

@@ -19,9 +19,9 @@ on:
 
 env:
   PHP_VERSION: "8.2"
-  # TODO: change to "stable" once 1.20.0 is released
+  # TODO: change to "stable" once 2.0.0 is released
   # DRIVER_VERSION: "stable"
-  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.20"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v2.x"
 
 jobs:
   psalm:

.github/workflows/static-analysis.yml

@@ -12,9 +12,9 @@ on:
       - "feature/*"
 
 env:
-  # TODO: change to "stable" once 1.20.0 is released
+  # TODO: change to "stable" once 2.0.0 is released
   # DRIVER_VERSION: "stable"
-  DRIVER_VERSION: "mongodb/mongo-php-driver@v1.20"
+  DRIVER_VERSION: "mongodb/mongo-php-driver@v2.x"
 
 jobs:
   phpunit:

.github/workflows/tests.yml

@@ -2,6 +2,7 @@ UPGRADE FROM 1.x to 2.0
 ========================
 
  * Classes in the namespace `MongoDB\Operation\` are `final`.
+ * All methods in interfaces and classes now define a return type.
 
 GridFS
 ------

UPGRADE-2.0.md

@@ -12,7 +12,7 @@
     "require": {
         "php": "^8.1",
         "ext-json": "*",
-        "ext-mongodb": "^1.20.0",
+        "ext-mongodb": "^2.0",
         "composer-runtime-api": "^2.0",
         "psr/log": "^1.1.4|^2|^3",
         "symfony/polyfill-php80": "^1.27",

composer.json

@@ -133,14 +133,6 @@
     </rule>
 
 
-    <!-- *********************************************************** -->
-    <!-- Require native type hints for all code without a BC promise -->
-    <!-- *********************************************************** -->
-    <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingNativeTypeHint">
-        <exclude-pattern>src</exclude-pattern>
-    </rule>
-
-
     <!-- ************************************************************* -->
     <!-- Ignore errors for certain files where this is part of the API -->
     <!-- ************************************************************* -->