Skip to content

Commit 3c5819a

Browse files
GromNaNGromNaN
committed
Revert "Split GridFS bucket tests to improve performance of unit tests"
This reverts commit 1d831e2.
1 parent 71c286e commit 3c5819a

File tree

2 files changed

+162
-240
lines changed

2 files changed

+162
-240
lines changed

‎tests/GridFS/BucketFunctionalTest.php

Lines changed: 162 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,24 @@
33
namespace MongoDB\Tests\GridFS;
44

55
use MongoDB\BSON\Binary;
6+
use MongoDB\BSON\ObjectId;
7+
use MongoDB\Collection;
8+
use MongoDB\Driver\ReadConcern;
9+
use MongoDB\Driver\ReadPreference;
10+
use MongoDB\Driver\WriteConcern;
611
use MongoDB\Exception\InvalidArgumentException;
712
use MongoDB\GridFS\Bucket;
13+
use MongoDB\GridFS\CollectionWrapper;
814
use MongoDB\GridFS\Exception\CorruptFileException;
915
use MongoDB\GridFS\Exception\FileNotFoundException;
1016
use MongoDB\GridFS\Exception\StreamException;
1117
use MongoDB\Model\BSONDocument;
1218
use MongoDB\Model\IndexInfo;
1319
use MongoDB\Operation\ListIndexes;
20+
use MongoDB\Tests\Fixtures\Codec\TestDocumentCodec;
1421
use MongoDB\Tests\Fixtures\Codec\TestFileCodec;
1522
use MongoDB\Tests\Fixtures\Document\TestFile;
23+
use ReflectionMethod;
1624
use stdClass;
1725

1826
use function array_merge;
@@ -43,6 +51,58 @@
4351
*/
4452
class BucketFunctionalTest extends FunctionalTestCase
4553
{
54+
/** @doesNotPerformAssertions */
55+
public function testValidConstructorOptions(): void
56+
{
57+
new Bucket($this->manager, $this->getDatabaseName(), [
58+
'bucketName' => 'test',
59+
'chunkSizeBytes' => 8192,
60+
'readConcern' => new ReadConcern(ReadConcern::LOCAL),
61+
'readPreference' => new ReadPreference(ReadPreference::PRIMARY),
62+
'writeConcern' => new WriteConcern(WriteConcern::MAJORITY, 1000),
63+
'disableMD5' => true,
64+
]);
65+
}
66+
67+
/** @dataProvider provideInvalidConstructorOptions */
68+
public function testConstructorOptionTypeChecks(array $options): void
69+
{
70+
$this->expectException(InvalidArgumentException::class);
71+
new Bucket($this->manager, $this->getDatabaseName(), $options);
72+
}
73+
74+
public static function provideInvalidConstructorOptions()
75+
{
76+
return self::createOptionDataProvider([
77+
'bucketName' => self::getInvalidStringValues(true),
78+
'chunkSizeBytes' => self::getInvalidIntegerValues(true),
79+
'codec' => self::getInvalidDocumentCodecValues(),
80+
'disableMD5' => self::getInvalidBooleanValues(true),
81+
'readConcern' => self::getInvalidReadConcernValues(),
82+
'readPreference' => self::getInvalidReadPreferenceValues(),
83+
'typeMap' => self::getInvalidArrayValues(),
84+
'writeConcern' => self::getInvalidWriteConcernValues(),
85+
]);
86+
}
87+
88+
public function testConstructorShouldRequireChunkSizeBytesOptionToBePositive(): void
89+
{
90+
$this->expectException(InvalidArgumentException::class);
91+
$this->expectExceptionMessage('Expected "chunkSizeBytes" option to be >= 1, 0 given');
92+
new Bucket($this->manager, $this->getDatabaseName(), ['chunkSizeBytes' => 0]);
93+
}
94+
95+
public function testConstructorWithCodecAndTypeMapOptions(): void
96+
{
97+
$options = [
98+
'codec' => new TestDocumentCodec(),
99+
'typeMap' => ['root' => 'array', 'document' => 'array'],
100+
];
101+
102+
$this->expectExceptionObject(InvalidArgumentException::cannotCombineCodecAndTypeMap());
103+
new Bucket($this->manager, $this->getDatabaseName(), $options);
104+
}
105+
46106
/** @dataProvider provideInputDataAndExpectedChunks */
47107
public function testDelete($input, $expectedChunks): void
48108
{
@@ -147,6 +207,13 @@ public function testDownloadToStream($input): void
147207
$this->assertStreamContents($input, $destination);
148208
}
149209

210+
/** @dataProvider provideInvalidStreamValues */
211+
public function testDownloadToStreamShouldRequireDestinationStream($destination): void
212+
{
213+
$this->expectException(InvalidArgumentException::class);
214+
$this->bucket->downloadToStream('id', $destination);
215+
}
216+
150217
public static function provideInvalidStreamValues(): array
151218
{
152219
return self::wrapValuesForDataProvider(self::getInvalidStreamValues());
@@ -193,6 +260,13 @@ public function testDownloadToStreamByName(): void
193260
$this->assertStreamContents('baz', $destination);
194261
}
195262

263+
/** @dataProvider provideInvalidStreamValues */
264+
public function testDownloadToStreamByNameShouldRequireDestinationStream($destination): void
265+
{
266+
$this->expectException(InvalidArgumentException::class);
267+
$this->bucket->downloadToStreamByName('filename', $destination);
268+
}
269+
196270
/** @dataProvider provideNonexistentFilenameAndRevision */
197271
public function testDownloadToStreamByNameShouldRequireFilenameAndRevisionToExist($filename, $revision): void
198272
{
@@ -378,6 +452,43 @@ public function testFindOneResetsInheritedBucketCodec(): void
378452
$this->assertSame(6, $fileDocument->length);
379453
}
380454

455+
public function testGetBucketNameWithCustomValue(): void
456+
{
457+
$bucket = new Bucket($this->manager, $this->getDatabaseName(), ['bucketName' => 'custom_fs']);
458+
459+
$this->assertEquals('custom_fs', $bucket->getBucketName());
460+
}
461+
462+
public function testGetBucketNameWithDefaultValue(): void
463+
{
464+
$this->assertEquals('fs', $this->bucket->getBucketName());
465+
}
466+
467+
public function testGetChunksCollection(): void
468+
{
469+
$chunksCollection = $this->bucket->getChunksCollection();
470+
471+
$this->assertInstanceOf(Collection::class, $chunksCollection);
472+
$this->assertEquals('fs.chunks', $chunksCollection->getCollectionName());
473+
}
474+
475+
public function testGetChunkSizeBytesWithCustomValue(): void
476+
{
477+
$bucket = new Bucket($this->manager, $this->getDatabaseName(), ['chunkSizeBytes' => 8192]);
478+
479+
$this->assertEquals(8192, $bucket->getChunkSizeBytes());
480+
}
481+
482+
public function testGetChunkSizeBytesWithDefaultValue(): void
483+
{
484+
$this->assertEquals(261120, $this->bucket->getChunkSizeBytes());
485+
}
486+
487+
public function testGetDatabaseName(): void
488+
{
489+
$this->assertEquals($this->getDatabaseName(), $this->bucket->getDatabaseName());
490+
}
491+
381492
public function testGetFileDocumentForStreamUsesTypeMap(): void
382493
{
383494
$metadata = ['foo' => 'bar'];
@@ -469,6 +580,21 @@ public function testGetFileIdForStreamWithWritableStream(): void
469580
$this->assertEquals(1, $this->bucket->getFileIdForStream($stream));
470581
}
471582

583+
/** @dataProvider provideInvalidGridFSStreamValues */
584+
public function testGetFileIdForStreamShouldRequireGridFSStreamResource($stream): void
585+
{
586+
$this->expectException(InvalidArgumentException::class);
587+
$this->bucket->getFileIdForStream($stream);
588+
}
589+
590+
public function testGetFilesCollection(): void
591+
{
592+
$filesCollection = $this->bucket->getFilesCollection();
593+
594+
$this->assertInstanceOf(Collection::class, $filesCollection);
595+
$this->assertEquals('fs.files', $filesCollection->getCollectionName());
596+
}
597+
472598
/** @dataProvider provideInputDataAndExpectedChunks */
473599
public function testOpenDownloadStream($input): void
474600
{
@@ -815,6 +941,42 @@ public function testDanglingOpenWritableStreamWithGlobalStreamWrapperAlias(): vo
815941
$this->assertSame(14, $fileDocument->length);
816942
}
817943

944+
public function testResolveStreamContextForRead(): void
945+
{
946+
$stream = $this->bucket->openUploadStream('filename');
947+
fwrite($stream, 'foobar');
948+
fclose($stream);
949+
950+
$method = new ReflectionMethod($this->bucket, 'resolveStreamContext');
951+
$method->setAccessible(true);
952+
953+
$context = $method->invokeArgs($this->bucket, ['gridfs://bucket/filename', 'rb', []]);
954+
955+
$this->assertIsArray($context);
956+
$this->assertArrayHasKey('collectionWrapper', $context);
957+
$this->assertInstanceOf(CollectionWrapper::class, $context['collectionWrapper']);
958+
$this->assertArrayHasKey('file', $context);
959+
$this->assertIsObject($context['file']);
960+
$this->assertInstanceOf(ObjectId::class, $context['file']->_id);
961+
$this->assertSame('filename', $context['file']->filename);
962+
}
963+
964+
public function testResolveStreamContextForWrite(): void
965+
{
966+
$method = new ReflectionMethod($this->bucket, 'resolveStreamContext');
967+
$method->setAccessible(true);
968+
969+
$context = $method->invokeArgs($this->bucket, ['gridfs://bucket/filename', 'wb', []]);
970+
971+
$this->assertIsArray($context);
972+
$this->assertArrayHasKey('collectionWrapper', $context);
973+
$this->assertInstanceOf(CollectionWrapper::class, $context['collectionWrapper']);
974+
$this->assertArrayHasKey('filename', $context);
975+
$this->assertSame('filename', $context['filename']);
976+
$this->assertArrayHasKey('options', $context);
977+
$this->assertSame(['chunkSizeBytes' => 261120, 'disableMD5' => false], $context['options']);
978+
}
979+
818980
/**
819981
* Asserts that an index with the given name exists for the collection.
820982
*

0 commit comments

Comments
 (0)