Skip to content

Commit 65bbd1b

Browse files
authored
PHPC-2503: Conditionally allow more concise output for libbson 1.30 (#1779)
mongodb/mongo-c-driver@f2c1bb7 reduced the whitespace for empty arrays and documents. The EXPECTF pattern is necessary for compatibility with earlier versions of libbson, but it can be removed once libbson 1.30+ is formally required.
1 parent 45c8aeb commit 65bbd1b

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

tests/bson/bson-encode-001.phpt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ foreach($tests as $n => $test) {
3939
?>
4040
===DONE===
4141
<?php exit(0); ?>
42-
--EXPECT--
42+
--EXPECTF--
4343
Test#0 { "hello" : "world" }
4444
0 : 16 00 00 00 02 68 65 6c 6c 6f 00 06 00 00 00 77 [.....hello.....w]
4545
10 : 6f 72 6c 64 00 00 [orld..]
@@ -98,7 +98,7 @@ Test#16 { "foo" : "test", "0" : "foo", "1" : "bar" }
9898
0 : 29 00 00 00 02 66 6f 6f 00 05 00 00 00 74 65 73 [)....foo.....tes]
9999
10 : 74 00 02 30 00 04 00 00 00 66 6f 6f 00 02 31 00 [t..0.....foo..1.]
100100
20 : 04 00 00 00 62 61 72 00 00 [....bar..]
101-
Test#17 { "int" : { "$numberInt" : "3" }, "boolean" : true, "array" : [ "foo", "bar" ], "object" : { }, "string" : "test", "3" : "test" }
101+
Test#17 { "int" : { "$numberInt" : "3" }, "boolean" : true, "array" : [ "foo", "bar" ], "object" : { %w}, "string" : "test", "3" : "test" }
102102
0 : 64 00 00 00 10 69 6e 74 00 03 00 00 00 08 62 6f [d....int......bo]
103103
10 : 6f 6c 65 61 6e 00 01 04 61 72 72 61 79 00 1b 00 [olean...array...]
104104
20 : 00 00 02 30 00 04 00 00 00 66 6f 6f 00 02 31 00 [...0.....foo..1.]
@@ -123,7 +123,7 @@ Test#21 { "0" : { "foo" : "test", "0" : "foo", "1" : "bar" } }
123123
10 : 05 00 00 00 74 65 73 74 00 02 30 00 04 00 00 00 [....test..0.....]
124124
20 : 66 6f 6f 00 02 31 00 04 00 00 00 62 61 72 00 00 [foo..1.....bar..]
125125
30 : 00 [.]
126-
Test#22 { "0" : { "int" : { "$numberInt" : "3" }, "boolean" : true, "array" : [ "foo", "bar" ], "object" : { }, "string" : "test", "3" : "test" } }
126+
Test#22 { "0" : { "int" : { "$numberInt" : "3" }, "boolean" : true, "array" : [ "foo", "bar" ], "object" : { %w}, "string" : "test", "3" : "test" } }
127127
0 : 6c 00 00 00 03 30 00 64 00 00 00 10 69 6e 74 00 [l....0.d....int.]
128128
10 : 03 00 00 00 08 62 6f 6f 6c 65 61 6e 00 01 04 61 [.....boolean...a]
129129
20 : 72 72 61 79 00 1b 00 00 00 02 30 00 04 00 00 00 [rray......0.....]

tests/bson/bson-encode-004.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ object(Person)#%d (5) {
7171
["secret":protected]=>
7272
string(24) "Hannes confidential info"
7373
}
74-
Test { "0" : { "__pclass" : { "$binary" : { "base64" : "UGVyc29u", "subType" : "80" } }, "name" : "Hannes", "age" : { "$numberInt" : "42" }, "addresses" : [ { "__pclass" : { "$binary" : { "base64" : "QWRkcmVzcw==", "subType" : "80" } }, "zip" : { "$numberInt" : "94086" }, "country" : "USA" }, { "__pclass" : { "$binary" : { "base64" : "QWRkcmVzcw==", "subType" : "80" } }, "zip" : { "$numberInt" : "200" }, "country" : "Iceland" } ], "friends" : [ { "__pclass" : { "$binary" : { "base64" : "UGVyc29u", "subType" : "80" } }, "name" : "Jeremy", "age" : { "$numberInt" : "21" }, "addresses" : [ ], "friends" : [ ] } ] } }
74+
Test { "0" : { "__pclass" : { "$binary" : { "base64" : "UGVyc29u", "subType" : "80" } }, "name" : "Hannes", "age" : { "$numberInt" : "42" }, "addresses" : [ { "__pclass" : { "$binary" : { "base64" : "QWRkcmVzcw==", "subType" : "80" } }, "zip" : { "$numberInt" : "94086" }, "country" : "USA" }, { "__pclass" : { "$binary" : { "base64" : "QWRkcmVzcw==", "subType" : "80" } }, "zip" : { "$numberInt" : "200" }, "country" : "Iceland" } ], "friends" : [ { "__pclass" : { "$binary" : { "base64" : "UGVyc29u", "subType" : "80" } }, "name" : "Jeremy", "age" : { "$numberInt" : "21" }, "addresses" : [ %w], "friends" : [ %w] } ] } }
7575
0 : 23 01 00 00 03 30 00 1b 01 00 00 05 5f 5f 70 63 [#....0......__pc]
7676
10 : 6c 61 73 73 00 06 00 00 00 80 50 65 72 73 6f 6e [lass......Person]
7777
20 : 02 6e 61 6d 65 00 07 00 00 00 48 61 6e 6e 65 73 [.name.....Hannes]

tests/bson/bson-encode-005.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ var_dump($ret);
1919
===DONE===
2020
<?php exit(0); ?>
2121
--EXPECTF--
22-
Test { "emptyarray" : [ ], "emptyclass" : { } }
22+
Test { "emptyarray" : [ %w], "emptyclass" : { %w} }
2323
0 : 27 00 00 00 04 65 6d 70 74 79 61 72 72 61 79 00 ['....emptyarray.]
2424
10 : 05 00 00 00 00 03 65 6d 70 74 79 63 6c 61 73 73 [......emptyclass]
2525
20 : 00 05 00 00 00 00 00 [.......]

tests/readPreference/readpreference-bsonserialize-001.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ foreach ($tests as $test) {
2424
?>
2525
===DONE===
2626
<?php exit(0); ?>
27-
--EXPECT--
27+
--EXPECTF--
2828
{ "mode" : "primary" }
2929
{ "mode" : "primaryPreferred" }
3030
{ "mode" : "secondary" }
3131
{ "mode" : "secondaryPreferred" }
3232
{ "mode" : "nearest" }
3333
{ "mode" : "primary" }
3434
{ "mode" : "secondary", "tags" : [ { "dc" : "ny" } ] }
35-
{ "mode" : "secondary", "tags" : [ { "dc" : "ny" }, { "dc" : "sf", "use" : "reporting" }, { } ] }
35+
{ "mode" : "secondary", "tags" : [ { "dc" : "ny" }, { "dc" : "sf", "use" : "reporting" }, { %w} ] }
3636
{ "mode" : "secondary", "maxStalenessSeconds" : { "$numberInt" : "1000" } }
3737
===DONE===

0 commit comments

Comments
 (0)