Skip to content

Conversation

@nbbeeken
Copy link
Contributor

Description

What is changing?

  • update release please owner
  • make highlight use fetch and remove octokit
Is there new documentation needed for these changes?

What is the motivation for this change?

  • new source for release please
  • using fetch and "repository" variable makes copy pasting to other repos easier because there's now no owner/repo varaibles in the script that has to be changed.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 23, 2024 15:54
@nbbeeken nbbeeken requested a review from baileympearson June 3, 2024 19:14
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 3, 2024
@baileympearson baileympearson merged commit 9e7b76a into main Jun 4, 2024
@baileympearson baileympearson deleted the NODE-6170-release-please-owner branch June 4, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants