feat!(NODE-4704): remove deprecated ObjectId methods #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
added
the
Primary Review
durran
requested changes
Nov 23, 2022
Member
durran
left a comment
durran
left a comment
There was a problem hiding this comment.
Just minor test description changes per our test patterns.
durran
previously approved these changes
Nov 23, 2022
durran
added
Team Review
dariakp
requested changes
Nov 23, 2022
dariakp
requested changes
Nov 23, 2022
nbbeeken
force-pushed
the
NODE-4704-remove-deprecated-oid-methods
branch
from
96724ce to
6bfbff5
Compare
nbbeeken
force-pushed
the
NODE-4704-remove-deprecated-oid-methods
branch
from
6bfbff5 to
68eefb0
Compare
docs/upgrade-to-v5.md
Outdated
|
|
||
| ```ts | ||
| const oid = new ObjectId(); | ||
| const counterField = oid.id[9] << 16 | oid.id[10] << 8 | oid.id[11]; |
Contributor
There was a problem hiding this comment.
completely optional - should we consider just adding a simple getter that does this for users?
getCounter() : number { return this.id[9] << 16 | this.id[10] << 8 | this.id[11]; }
Contributor
Author
There was a problem hiding this comment.
Per the spec we should not have one: https://github.com/mongodb/specifications/blob/master/source/objectid.rst#counter
nbbeeken
force-pushed
the
NODE-4704-remove-deprecated-oid-methods
branch
from
68eefb0 to
d24d275
Compare
baileympearson
previously approved these changes
Nov 30, 2022
dariakp
requested changes
Nov 30, 2022
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
in the spirit of the spec, I think we shouldn't include the instructions for obtaining the counter (especially if we ever want to change the internal implementation); otherwise lgtm
nbbeeken
force-pushed
the
NODE-4704-remove-deprecated-oid-methods
branch
from
d24d275 to
685a6d0
Compare
dariakp
previously approved these changes
Nov 30, 2022
nbbeeken
force-pushed
the
NODE-4704-remove-deprecated-oid-methods
branch
from
5854054 to
6e21ac0
Compare
dariakp
approved these changes
Nov 30, 2022
baileympearson
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Removing deprecated ObjectId methods.
What is the motivation for this change?
Methods are deprecated, alternatives exist.
Double check the following
npm run lintscript<type>(NODE-xxxx)<!>: <description>