chore(eslint): make @typescript-eslint/no-unused-vars error (#2676)

* chore(eslint): make @typescript-eslint/no-unused-vars error

* log Running raw find

Author: mcasimir

configs/eslint-config-compass/index.js

@@ -6,6 +6,7 @@ const tsConfigurations = [
   'plugin:@typescript-eslint/recommended-requiring-type-checking',
 ];
 const tsRules = {
+  '@typescript-eslint/no-unused-vars': 'error',
   '@typescript-eslint/no-unsafe-assignment': 'off',
   '@typescript-eslint/no-unsafe-call': 'off',
   '@typescript-eslint/no-unsafe-member-access': 'off',
@@ -22,6 +23,7 @@ const testConfigurations = ['plugin:mocha/recommended'];
 const testRules = {
   'mocha/no-exclusive-tests': 'error',
   'mocha/no-hooks-for-single-case': 'off',
+  '@typescript-eslint/no-explicit-any': 'off',
 };
 
 module.exports = {

package.json

@@ -28,6 +28,7 @@
     "postpackages-publish": "git push && git push --tags",
     "packages-version": "lerna version --allow-branch main --no-push --no-private -m \"chore(release): Bump package versions\"",
     "release": "npm run release --workspace mongodb-compass --",
+    "reformat": "lerna run reformat --stream",
     "package-compass": "npm run package-compass --workspace=mongodb-compass --",
     "start": "npm run start --workspace=mongodb-compass",
     "test": "lerna run test --concurrency 1 --stream",

packages/connect-form/src/utils/connect-form-errors.ts

@@ -35,6 +35,7 @@ export type ConnectionFormError =
   | SSHTunnelFieldError;
 
 export function getConnectFormErrors(
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   connectionOptions: ConnectionOptions
 ): ConnectionFormError[] {
   return [];

packages/connect-form/src/utils/connect-form-warnings.ts

@@ -5,6 +5,7 @@ export interface ConnectionFormWarning {
 }
 
 export function getConnectFormWarnings(
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   connectionOptions: ConnectionOptions
 ): ConnectionFormWarning[] {
   return [];

packages/connections/src/components/connections.tsx

@@ -3,7 +3,6 @@ import React from 'react';
 import {
   Banner,
   BannerVariant,
-  MongoDBLogo,
   compassUIColors,
   spacing,
 } from '@mongodb-js/compass-components';
@@ -32,11 +31,6 @@ const connectStyles = css({
   background: compassUIColors.gray8,
 });
 
-const logoStyles = css({
-  margin: spacing[5],
-  marginBottom: 0,
-});
-
 const connectItemContainerStyles = css({
   position: 'relative',
   flexGrow: 1,

packages/data-service/src/data-service.ts

@@ -10,7 +10,6 @@ import {
   BulkWriteOptions,
   ClientSession,
   Collection,
-  CollectionInfo,
   CollStats,
   CommandFailedEvent,
   CommandSucceededEvent,
@@ -32,7 +31,6 @@ import {
   InsertManyResult,
   InsertOneOptions,
   InsertOneResult,
-  ListCollectionsOptions,
   MongoClient,
   MongoClientOptions,
   ServerClosedEvent,
@@ -912,6 +910,9 @@ class DataService extends EventEmitter {
       'Running raw find',
       { ns }
     );
+
+    logop(null);
+
     return this._collection(ns).find(filter, options);
   }
 

packages/data-service/src/instance-detail-helper.ts

@@ -139,7 +139,7 @@ export async function getInstance(
       featureCompatibilityVersion: 1,
     }).catch(() => null),
 
-    runCommand(adminDb, { atlasVersion: 1 }).catch((err) => {
+    runCommand(adminDb, { atlasVersion: 1 }).catch(() => {
       return { version: '', gitVersion: '' };
     }),
   ]);

packages/data-service/test/helpers.ts

@@ -1,4 +1,4 @@
-import { Db, MongoClient } from 'mongodb';
+import { MongoClient } from 'mongodb';
 
 type ClientMockOptions = {
   hosts: [{ host: string; port: number }];