chore(eslint-config): re-enable no-unsafe-declaration-merging rule

Author: gribnoysup

configs/eslint-config-compass/index.js

@@ -27,7 +27,6 @@ const extraTsRules = {
   '@typescript-eslint/no-base-to-string': 'warn',
   '@typescript-eslint/unbound-method': 'warn',
   '@typescript-eslint/no-duplicate-type-constituents': 'warn',
-  '@typescript-eslint/no-unsafe-declaration-merging': 'warn',
 };
 
 const tsRules = {

packages/compass-components/src/components/guide-cue/guide-cue-service.spec.ts

@@ -1,5 +1,5 @@
 import * as GuideCueGroups from './guide-cue-groups';
-import { GuideCueService, type Cue } from './guide-cue-service';
+import { GuideCueServiceImpl, type Cue } from './guide-cue-service';
 import { type GuideCueStorage } from './guide-cue-storage';
 import { expect } from 'chai';
 import {
@@ -30,14 +30,14 @@ GROUP_STEPS_MAP.set('group-one', 1);
 GROUP_STEPS_MAP.set('group-two', 2);
 
 describe('GuideCueService', function () {
-  let guideCueService: GuideCueService;
+  let guideCueService: GuideCueServiceImpl;
   let guideCueStorage: GuideCueStorage;
 
   const sandbox = Sinon.createSandbox();
 
   beforeEach(function () {
     guideCueStorage = new TestGuideCueStorage();
-    guideCueService = new GuideCueService(guideCueStorage);
+    guideCueService = new GuideCueServiceImpl(guideCueStorage);
   });
 
   before(function () {

packages/compass-components/src/components/guide-cue/guide-cue-service.ts

@@ -47,7 +47,10 @@ export type Cue = {
   isVisited: boolean;
 };
 
-export class GuideCueService extends EventTarget {
+export class GuideCueServiceImpl
+  extends EventTarget
+  implements GuideCueService
+{
   private _cues: Cue[] = [];
 
   private _activeGroupId: GroupName | null = null;
@@ -263,6 +266,6 @@ export class GuideCueService extends EventTarget {
   }
 }
 
-export const guideCueService = new GuideCueService(
+export const guideCueService = new GuideCueServiceImpl(
   new CompassGuideCueStorage()
 );