You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit applies several corrections to the module federation
sharing configurations in `share-internals-client.ts` and
`share-internals-server.ts` based on recent feedback:
1. **Removed Polyfill Sharing**:
- All shared configurations for polyfills (e.g., `unfetch`,
`isomorphic-unfetch`, `whatwg-fetch`, `object-assign`, `url`)
have been removed from `share-internals-client.ts`.
- Confirmed no such polyfill shares existed in
`share-internals-server.ts`.
2. **Restored Deterministic Key Generation**:
- Reverted the key generation logic for shared module configurations
in both `share-internals-client.ts` and `share-internals-server.ts`
to be deterministic (based on shareKey, layer, and index),
removing any `Math.random()` components.
3. **Verified `nodeModulesReconstructedLookup`**:
- Confirmed that React module configurations in `getReactGroupServer`
within `share-internals-server.ts` correctly maintain
`nodeModulesReconstructedLookup: false`, consistent with their
previous state in the analyzed file version.
These changes ensure a more precise and deterministic approach to
sharing Next.js internals for Module Federation.
0 commit comments