fix(mdjs-preview): initial setting should come from the element

Author: daKmoR

.changeset/fluffy-glasses-confess.md

@@ -0,0 +1,5 @@
+---
+'@mdjs/mdjs-preview': patch
+---
+
+Make sure initial settings are taken from the element if nothing is yet stored

packages/mdjs-preview/src/MdJsPreview.js

@@ -72,7 +72,7 @@ export class MdJsPreview extends LitElement {
     this.languages = [
       { key: 'en', name: 'English' },
       { key: 'en-US', name: 'English (United States)' },
-      { key: 'en-US', name: 'English (United Kingdom)' },
+      { key: 'en-GB', name: 'English (United Kingdom)' },
       { key: 'de', name: 'German' },
       { key: 'es', name: 'Spanish' },
       { key: 'fi', name: 'Finnish' },

packages/mdjs-preview/src/mdjsViewerSharedStates.js

@@ -40,6 +40,8 @@ function storeSettings() {
   }
 }
 
+let hasGlobalStateBeenSetBefore = false;
+
 function restoreSettings() {
   for (const _sharedStateKey of Object.keys(_sharedStates)) {
     const sharedStateKey = /** @type {keyof _sharedStates} */ (_sharedStateKey);
@@ -55,6 +57,7 @@ function restoreSettings() {
         default:
           _sharedStates[sharedStateKey] = restoredValue;
       }
+      hasGlobalStateBeenSetBefore = true;
     }
   }
 }
@@ -66,27 +69,30 @@ restoreSettings();
  * @param {import('./MdJsPreview.js').MdJsPreview} target
  */
 export function applySharedStates(target) {
-  for (const _sharedStateKey of Object.keys(_sharedStates)) {
-    const sharedStateKey = /** @type {keyof _sharedStates} */ (_sharedStateKey);
-    switch (sharedStateKey) {
-      case 'autoHeight':
-      case 'deviceMode':
-      case 'rememberSettings':
-      case 'edgeDistance':
-        target[sharedStateKey] = _sharedStates[sharedStateKey];
-        break;
-      default:
-        target[sharedStateKey] = _sharedStates[sharedStateKey];
+  if (hasGlobalStateBeenSetBefore) {
+    for (const _sharedStateKey of Object.keys(_sharedStates)) {
+      const sharedStateKey = /** @type {keyof _sharedStates} */ (_sharedStateKey);
+      switch (sharedStateKey) {
+        case 'autoHeight':
+        case 'deviceMode':
+        case 'rememberSettings':
+        case 'edgeDistance':
+          target[sharedStateKey] = _sharedStates[sharedStateKey];
+          break;
+        default:
+          target[sharedStateKey] = _sharedStates[sharedStateKey];
+      }
     }
+  } else {
+    _saveToSharedStates(target);
   }
 }
 
 /**
  *
  * @param {import('./MdJsPreview.js').MdJsPreview} target
- * @param {Function} subscribedFn
  */
-export function saveToSharedStates(target, subscribedFn) {
+function _saveToSharedStates(target) {
   let updated = false;
   for (const _sharedStateKey of Object.keys(_sharedStates)) {
     const sharedStateKey = /** @type {keyof _sharedStates} */ (_sharedStateKey);
@@ -102,8 +108,19 @@ export function saveToSharedStates(target, subscribedFn) {
           _sharedStates[sharedStateKey] = target[sharedStateKey];
       }
       updated = true;
+      hasGlobalStateBeenSetBefore = true;
     }
   }
+  return updated;
+}
+
+/**
+ *
+ * @param {import('./MdJsPreview.js').MdJsPreview} target
+ * @param {Function} subscribedFn
+ */
+export function saveToSharedStates(target, subscribedFn) {
+  const updated = _saveToSharedStates(target);
   if (updated) {
     storeSettings();
     for (const subscribeFn of subscribeFns) {