-
Notifications
You must be signed in to change notification settings - Fork 400
fix: generate default schema for tools with no params #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate default schema for tools with no params #446
Conversation
|
If this pr has been merged , the empty struct will be updated , how about wait for the newest schema description release? |
|
@jokemanfire Ideally this fix is merged, because it seems like clients in the wild do expect the object type to be present. Servers using rmcp 0.7.0 are not compatible with many clients due to the |
|
Then please add a todo comment. This should be updated according to the new specifications soon. |
|
It LGTM now if also OK with @jokemanfire The commit message |
c83cfe2 to
b2f77ad
Compare
|
@jokemanfire any reason that CI doesn't pass? thanks |
It should be CI's problem ,I will check. |
|
#458 fix rustdoc build by scoping |
717ec56
into
modelcontextprotocol:main
Motivation and Context
closes #445
provide empty object json schema when there is no params for a tool, following https://github.com/modelcontextprotocol/typescript-sdk/blob/c94ba4b43cd305e39d88985c73d6b9bc1153da84/src/server/mcp.ts#L1202-L1205
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context