Skip to content

Conversation

@vincent0426
Copy link
Contributor

Motivation and Context

closes #445

provide empty object json schema when there is no params for a tool, following https://github.com/modelcontextprotocol/typescript-sdk/blob/c94ba4b43cd305e39d88985c73d6b9bc1153da84/src/server/mcp.ts#L1202-L1205

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@github-actions github-actions bot added T-test Testing related changes T-macros Macro changes labels Sep 21, 2025
@jokemanfire
Copy link
Collaborator

If this pr has been merged , the empty struct will be updated , how about wait for the newest schema description release?
https://github.com/modelcontextprotocol/modelcontextprotocol/pull/881/files#diff-b562e63d9fb1f6bbb6ddf2807a7f4e9558662e454b33076540a053ae55e46fc0

@asm89
Copy link

asm89 commented Sep 25, 2025

@jokemanfire Ideally this fix is merged, because it seems like clients in the wild do expect the object type to be present. Servers using rmcp 0.7.0 are not compatible with many clients due to the {} being used to signal empty parametrs.

@jokemanfire
Copy link
Collaborator

Then please add a todo comment. This should be updated according to the new specifications soon.

@alexhancock
Copy link
Contributor

It LGTM now if also OK with @jokemanfire

The commit message input: fix: generate default schema for tools with no params could work

@vincent0426
Copy link
Contributor Author

@jokemanfire any reason that CI doesn't pass? thanks

@jokemanfire
Copy link
Collaborator

@jokemanfire any reason that CI doesn't pass? thanks

It should be CI's problem ,I will check.

@jokemanfire
Copy link
Collaborator

#458 fix rustdoc build by scoping

@jokemanfire jokemanfire merged commit 717ec56 into modelcontextprotocol:main Sep 26, 2025
19 of 21 checks passed
@github-actions github-actions bot mentioned this pull request Sep 26, 2025
@github-actions github-actions bot mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-macros Macro changes T-test Testing related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List tools fails when there are tools without parameters

4 participants