Skip to content

Conversation

@jfclere
Copy link
Member

@jfclere jfclere commented Feb 13, 2025

Fix for https://issues.redhat.com/browse/MODCLUSTER-852.
Changes in httpd-2.4.59 are causing the sockets to stop being reused, that results in many sockets in TIME_WAIT and on windows when doing a load tests to get "All workers are in error state" due to:
(OS 10048) Only one usage of each socket address (protocol/network address/port) is normally permitted.
because the OS runs out of sockets.
Note that increasing the number of socket in the OS helps to some extend:
netsh int ipv4 set dynamicport tcp start=9000 num=25000
netsh int ipv6 set dynamicport tcp start=9000 num=25000

Note the same fix is need in mod_proxy_cluster upstream.

@jfclere jfclere requested a review from jajik February 13, 2025 14:45
Copy link
Member

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream should go first, but that's not an issue as big as failing ci. But it doesn't look like your fault. I'll check it out.

@rhusar
Copy link
Member

rhusar commented Feb 13, 2025

Upstream should go first, but that's not an issue as big as failing ci. But it doesn't look like your fault. I'll check it out.

That's correct, though the order of opening doesn't matter, the order of merging is the crucial one. Thanks for policing ;-)

@jajik
Copy link
Member

jajik commented Feb 13, 2025

CI failure is caused by httpd. Hopefully it will be fixed soon.

apache/httpd#516

@jajik
Copy link
Member

jajik commented Feb 14, 2025

httpd is fixed, pipeline looks fine now. We need to merge the upstream PR first and then we can go with this one.

@jajik jajik added bug 1.3.x Issues and PRs for the 1.3.x branch labels Feb 14, 2025
Copy link
Member

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and upstream is merged.

@jajik jajik merged commit 22a64be into modcluster:1.3.x Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.3.x Issues and PRs for the 1.3.x branch bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants