Skip to content

Conversation

@jfclere
Copy link
Member

@jfclere jfclere commented Nov 19, 2024

Fix: https://issues.redhat.com/browse/MODCLUSTER-841

This change is NOT relevant in upstream, the http/ws logic is different.

@jfclere jfclere requested review from aogburn and jajik November 19, 2024 08:43
Copy link
Member

@jajik jajik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

http_worker = get_http_worker(s, worker);
if (http_worker != NULL) {
if (http_worker->s->status != worker->s->status ||
http_worker->s->error_time !=worker->s->error_time) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space after !=, but that's not a big deal

@jfclere
Copy link
Member Author

jfclere commented Nov 19, 2024

@jajik I have fixed the style coding missing space.

@jajik
Copy link
Member

jajik commented Nov 19, 2024

Thanks! Feel free to squash it into one commit.

@jfclere
Copy link
Member Author

jfclere commented Nov 19, 2024

@jajik Done

@jajik jajik added 1.3.x Issues and PRs for the 1.3.x branch bug labels Nov 20, 2024
@jajik jajik merged commit 937ceb4 into modcluster:1.3.x Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.3.x Issues and PRs for the 1.3.x branch bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants