Skip to content

Commit 39d62de

Browse files
committed
file: Fix double-free along error path
$ mkdir j; nbdkit -U - -fv -r file dir=j \ --run 'nbdsh --opt-mode -u "$uri" -c "h.opt_info()"' crashes at: libguestfs#7 0x00007f244789f6ae in __GI___libc_free (mem=0x7f2440000ee0) at malloc.c:3386 libguestfs#8 0x00007f2447f1a5da in file_open (readonly=1) at /home/rjones/d/nbdkit/plugins/file/file.c:615 Reported-by: Eric Blake
1 parent 73b58dc commit 39d62de

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

plugins/file/file.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -504,7 +504,6 @@ open_file_by_name (struct handle *h, int readonly, int dfd, const char *file)
504504
}
505505
if (h->fd == -1) {
506506
nbdkit_error ("open: %s: %m", file);
507-
free (h);
508507
return -1;
509508
}
510509

0 commit comments

Comments
 (0)