Add tx output route to API server #1969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImplOfAnImpl
approved these changes
Sep 17, 2025
Comment on lines
+584
to
+585
| let utxo = db_tx | ||
| .get_utxo(outpoint) |
Contributor
There was a problem hiding this comment.
I must say I was surprised to find out that get_utxo actually returns any txos, not just unspent ones.
Perhaps we should add a TODO somewhere to revamp the naming, both in the code and in the db?
P.S. Also, struct Utxo is not a utxo, but struct LockedUtxo is, it seems.
And in the db ml.utxo contains any txos, even spent ones, while ml.locked_utxo seems to contain only unspent txos indeed.
This is very confusing.
Contributor
Author
There was a problem hiding this comment.
I guess the names should be changed.
both utxo and locked_utxo have both spent and unspent, nothing in the tables is ever deleted only inserted.
locked_utxo table is just to truck the unlock periods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New endpoint in API server to get a single transaction output and its spent state.