Allow multiple FillOrder v1 txs to co-exist in the mempool #1937
+1,365
−270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, mempool's
enum TxDependency'sOrderV1Accountvariant only contained the order id (throughAccountType::Order), which would make all transactions with order v1 inputs for the same order conflict with each other.The fix that I've ended up with is that I've just removed the
OrderV1Accountvariant fromTxDependency.This is OK because we rely on the tx verifier to check for conflicts anyway.
I also cleaned up
TxDependencya little, removing the redundantstruct TxAccountDependency.