Skip to content

Commit afd3ced

Browse files
Merge pull request #400 from middlewarehq/GROW-1559
Update default sync days and make default sync days configurable in env
2 parents 7d40038 + 817ea36 commit afd3ced

File tree

6 files changed

+26
-4
lines changed

6 files changed

+26
-4
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,7 @@ To set up middleware locally, follow these steps:
271271
REDIS_PORT=6385
272272
ANALYTICS_SERVER_PORT=9696
273273
SYNC_SERVER_PORT=9697
274+
DEFAULT_SYNC_DAYS=31
274275
```
275276

276277
- Start the backend servers

backend/analytics_server/mhq/service/code/sync/etl_handler.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from os import getenv
12
from datetime import datetime, timedelta
23
from typing import List
34

@@ -19,6 +20,11 @@
1920

2021

2122
class CodeETLHandler:
23+
24+
DEFAULT_SYNC_DAYS = (
25+
int(getenv("DEFAULT_SYNC_DAYS")) if getenv("DEFAULT_SYNC_DAYS") else 31
26+
)
27+
2228
def __init__(
2329
self,
2430
code_repo_service: CodeRepoService,
@@ -92,7 +98,10 @@ def __sync_revert_prs_mapping(
9298
LOG.error(f"Error syncing revert PRs for repo {org_repo.name}: {str(e)}")
9399
raise e
94100

95-
def __get_org_repo_bookmark(self, org_repo: OrgRepo, default_sync_days: int = 31):
101+
def __get_org_repo_bookmark(
102+
self, org_repo: OrgRepo, default_sync_days: int = DEFAULT_SYNC_DAYS
103+
):
104+
96105
bookmark = self.code_repo_service.get_org_repo_bookmark(
97106
org_repo, BookmarkType.PR
98107
)

backend/analytics_server/mhq/service/incidents/sync/etl_handler.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from os import getenv
12
from datetime import timedelta
23
from typing import List
34

@@ -17,6 +18,11 @@
1718

1819

1920
class IncidentsETLHandler:
21+
22+
DEFAULT_SYNC_DAYS = (
23+
int(getenv("DEFAULT_SYNC_DAYS")) if getenv("DEFAULT_SYNC_DAYS") else 31
24+
)
25+
2026
def __init__(
2127
self,
2228
provider: IncidentProvider,
@@ -67,7 +73,7 @@ def _sync_service_incidents(self, service: OrgIncidentService):
6773
return
6874

6975
def __get_incidents_bookmark(
70-
self, service: OrgIncidentService, default_sync_days: int = 31
76+
self, service: OrgIncidentService, default_sync_days: int = DEFAULT_SYNC_DAYS
7177
) -> IncidentsBookmark:
7278
bookmark = self.incident_repo_service.get_incidents_bookmark(
7379
str(service.id), IncidentBookmarkType.SERVICE, self.provider

backend/analytics_server/mhq/service/workflows/sync/etl_github_actions_handler.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
from mhq.utils.log import LOG
2121
from mhq.utils.time import ISO_8601_DATE_FORMAT, time_now
2222

23-
DEFAULT_WORKFLOW_SYNC_DAYS = 31
2423
WORKFLOW_PROCESSING_CHUNK_SIZE = 100
2524

2625

backend/analytics_server/mhq/service/workflows/sync/etl_handler.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from os import getenv
12
from datetime import timedelta
23
from typing import List, Tuple
34
from uuid import uuid4
@@ -20,6 +21,11 @@
2021

2122

2223
class WorkflowETLHandler:
24+
25+
DEFAULT_SYNC_DAYS = (
26+
int(getenv("DEFAULT_SYNC_DAYS")) if getenv("DEFAULT_SYNC_DAYS") else 31
27+
)
28+
2329
def __init__(
2430
self,
2531
code_repo_service: CodeRepoService,
@@ -99,7 +105,7 @@ def _sync_repo_workflow(self, org_repo: OrgRepo, repo_workflow: RepoWorkflow):
99105
return
100106

101107
def __get_repo_workflow_bookmark(
102-
self, repo_workflow: RepoWorkflow, default_sync_days: int = 31
108+
self, repo_workflow: RepoWorkflow, default_sync_days: int = DEFAULT_SYNC_DAYS
103109
) -> RepoWorkflowRunsBookmark:
104110
repo_workflow_bookmark = (
105111
self.workflow_repo_service.get_repo_workflow_runs_bookmark(repo_workflow.id)

env.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,4 @@ ANALYTICS_SERVER_PORT=9696
1919
INTERNAL_API_BASE_URL=http://localhost:9696
2020
INTERNAL_SYNC_API_BASE_URL=http://localhost:9697
2121
NEXT_PUBLIC_APP_ENVIRONMENT="development"
22+
DEFAULT_SYNC_DAYS=31

0 commit comments

Comments
 (0)