Skip to content

Add directive to ensure we serialize DictionaryEntry types. #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2021
Merged

Add directive to ensure we serialize DictionaryEntry types. #942

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1a443d
Add directive to ensure we serialize DictionaryEntry types.
peombwa Nov 18, 2021
2414d7c
Merge branch 'dev' into bugfixes/DeserializationDepth
peombwa Nov 18, 2021
e2145c9
Merge branch 'dev' into bugfixes/DeserializationDepth
peombwa Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/readme.graph.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,11 @@ directive:
// Changes excludes hashset to a case-insensitive hashset.
let fromJsonRegex = /(\s*FromJson<\w*>\s*\(JsonObject\s*json\s*,\s*System\.Collections\.Generic\.IDictionary.*)(\s*)({)/gm
$ = $.replace(fromJsonRegex, '$1$2$3\n$2 if (excludes != null){ excludes = new System.Collections.Generic.HashSet<string>(excludes, global::System.StringComparer.OrdinalIgnoreCase);}');

// Serialize DictionaryEntry struct as a value type.
let dictionaryEntrySerializer = 'if (vValue is System.Collections.DictionaryEntry deValue){return new JsonObject { { deValue.Key.ToString(), ToJsonValue(deValue.Value) } };}';
let valueTypeSerializerRegex = /(private\s*static\s*JsonNode\s*ToJsonValue\(ValueType vValue\)\s*{\s*)/gm
$ = $.replace(valueTypeSerializerRegex, `$1 ${dictionaryEntrySerializer}\n`);
return $;
}

Expand Down