Debug local bash not found in wsl #273667
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where Unix-style paths (particularly for bash and other Unix shells) were being incorrectly converted from forward slashes to backslashes on Windows, causing issues when these paths are intended for WSL or other Unix-like environments.
Key Changes:
- Added logic to detect Unix-style paths before performing path conversion
- Implemented
_isUnixStylePath()method to identify paths that should retain Unix format
| } | ||
| // Common Unix shell executables that might be found in PATH | ||
| const unixShells = ['bash', 'zsh', 'fish', 'sh', 'dash', 'tcsh', 'csh']; | ||
| const basename = path.split(/[\\/\\\\]/).pop()?.toLowerCase() || ''; |
There was a problem hiding this comment.
The regex pattern /[\\/\\\\]/ contains escaped characters that don't make sense. The pattern should be /[\\/]/ to match either forward slash or backslash. The double-escaped backslash \\\\ in the character class is redundant and incorrect.
| const basename = path.split(/[\\/\\\\]/).pop()?.toLowerCase() || ''; | |
| const basename = path.split(/[\\/]/).pop()?.toLowerCase() || ''; |
| // Common Unix shell executables that might be found in PATH | ||
| const unixShells = ['bash', 'zsh', 'fish', 'sh', 'dash', 'tcsh', 'csh']; | ||
| const basename = path.split(/[\\/\\\\]/).pop()?.toLowerCase() || ''; | ||
| if (unixShells.includes(basename) && !path.includes(':') && !path.includes('\\\\')) { |
There was a problem hiding this comment.
The condition !path.includes('\\\\') checks for double backslashes, but it should check for a single backslash !path.includes('\\') to detect Windows-style paths. The current check would miss paths containing single backslashes.
| if (unixShells.includes(basename) && !path.includes(':') && !path.includes('\\\\')) { | |
| if (unixShells.includes(basename) && !path.includes(':') && !path.includes('\\')) { |
No description provided.