Extension bisect does not consider "dependent" extensions when choosing what to disable

[fiksen99]

Suppose I have 4 extensions installed. Extension B has a dependency on A, and extension Y has a dependency on X. When running extension bisect, the bisect can select extensions A and X as the first two extensions to disable. However in this case, B and Y cannot be activated as the extensions they depend on are disabled, so the bisect runs with no extensions enabled. We should consider dependencies when bisecting, and only disable an extension if all other dependents of that extension have been disable by bisect.

[jrieken]

@sandy081 is there a way to know the dependency graph of extensions?

[sandy081]

Here is the util function to get all dependecies of an extension

vscode/src/vs/platform/extensionManagement/common/extensionManagementUtil.ts

Lines 132 to 149 in d2d6c11

	export function getExtensionDependencies(installedExtensions: ReadonlyArray<IExtension>, extension: IExtension): IExtension[] {
	const dependencies: IExtension[] = [];
	const extensions = extension.manifest.extensionDependencies?.slice(0) ?? [];
	while (extensions.length) {
	const id = extensions.shift();
	if (id && dependencies.every(e => !areSameExtensions(e.identifier, { id }))) {
	const ext = installedExtensions.filter(e => areSameExtensions(e.identifier, { id }));
	if (ext.length === 1) {
	dependencies.push(ext[0]);
	extensions.push(...ext[0].manifest.extensionDependencies?.slice(0) ?? []);
	}
	}
	}
	return dependencies;
	}