From 8f827f3dfe73432c5dd10e815cef0e3b9ec21f43 Mon Sep 17 00:00:00 2001 From: MikhailArkhipov Date: Fri, 13 Dec 2019 14:32:35 -0800 Subject: [PATCH 1/2] Bind function to class --- src/client/activation/languageServer/languageClientMiddleware.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/client/activation/languageServer/languageClientMiddleware.ts b/src/client/activation/languageServer/languageClientMiddleware.ts index 5af9e4768e28..9c0334efeaf0 100644 --- a/src/client/activation/languageServer/languageClientMiddleware.ts +++ b/src/client/activation/languageServer/languageClientMiddleware.ts @@ -58,6 +58,7 @@ export class LanguageClientMiddleware implements Middleware { private connected = false; // Default to not forwarding to VS code. public constructor(private readonly surveyBanner: IPythonExtensionBanner) { + this.handleDiagnostics = this.handleDiagnostics.bind(this); // VS Code calls function without context. } public connect() { From 29318b94b80c7c3ed2451f0762dec48803fc8556 Mon Sep 17 00:00:00 2001 From: MikhailArkhipov Date: Mon, 16 Dec 2019 09:20:36 -0800 Subject: [PATCH 2/2] Add news --- news/2 Fixes/9096.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/2 Fixes/9096.md diff --git a/news/2 Fixes/9096.md b/news/2 Fixes/9096.md new file mode 100644 index 000000000000..394e9660e87b --- /dev/null +++ b/news/2 Fixes/9096.md @@ -0,0 +1 @@ +Fix issue that prevented language server diagnostics from being published.