Skip to content

Prevent tool configuration if there's no selected interpreter #9756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kimadeline opened this issue Jan 24, 2020 · 4 comments
Closed

Prevent tool configuration if there's no selected interpreter #9756

kimadeline opened this issue Jan 24, 2020 · 4 comments
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on

Comments

@kimadeline
Copy link

kimadeline commented Jan 24, 2020 •
edited
Loading

Continuing on the work of #7750 , we should not let the user select a linter, discover tests or configure their test framework if there's no selected interpreter:

image

Suggestion from @karthiknadig : display the "no interpreter selected" prompt instead.
@kimadeline kimadeline added bug Issue identified by VS Code Team member as probable bug feature-* triage-needed Needs assignment to the proper sub-team labels Jan 24, 2020
@kimadeline kimadeline changed the title Prevent linting and test configuration if there's no selected interpreter Prevent tool configuration if there's no selected interpreter Jan 24, 2020
@luabud
Copy link
Member

luabud commented Jan 25, 2020

just to be clear, the idea is to not show this if no interpreter is selected, instead just show "no interpreter selected", right?
just confirming because I think this prompt should still be shown if test discovery is triggered but the test features are not configured.

@kimadeline
Copy link
Author

Yes, show "no interpreter selected" if the user doesn't have a selected interpreter and tries to select a linter, discover tests or configure tests (maybe if they try to format the document as well?).

@luabud
Copy link
Member

luabud commented Jan 27, 2020

if they try to format the document as well

Yes definitely! Good call 😊

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jan 27, 2020
@luabud luabud added area-environments Features relating to handling interpreter environments and removed feature-* labels May 13, 2020
@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@luabud
Copy link
Member

luabud commented Aug 19, 2022

Done via #19481

@luabud luabud closed this as completed Aug 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brettcannon @karthiknadig @karrtikr @luabud @kimadeline