Skip to content

Ensure messages are not displayed and awaited upon in activate methods #7702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue Oct 1, 2019 · 1 comment
Closed

Ensure messages are not displayed and awaited upon in activate methods #7702

DonJayamanne opened this issue Oct 1, 2019 · 1 comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

DonJayamanne commented Oct 1, 2019 •
edited
Loading

When using the IExtensionActivationService interface ensure messageboxes are not displayed and awaited upon in the activate method.
Else this will block loading the extension until the message is dismissed.

Note: We have already created custom linter rules for the extension.

Also note, if the user doesn't dismiss the message, it will get hidden and user will not know why extension fails to load.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Oct 1, 2019
@DonJayamanne DonJayamanne added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Oct 1, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 1, 2019
@DonJayamanne DonJayamanne self-assigned this Oct 1, 2019
@DonJayamanne DonJayamanne mentioned this issue Oct 1, 2019
Closed
@DonJayamanne DonJayamanne removed their assignment Oct 1, 2019
@luabud
Copy link
Member

luabud commented Oct 27, 2020

Closing as stale

@luabud luabud closed this as completed Oct 27, 2020
@ghost ghost removed the needs PR label Oct 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @luabud